Giter VIP home page Giter VIP logo

pwa-app-updates's People

Contributors

185driver avatar dependabot[bot] avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

pwa-app-updates's Issues

controllerChange event listener in app.vue causes havoc when private network or not https

Just an fyi, this line in App.vue Created event:
navigator.serviceWorker.addEventListener("controllerchange", () => {
will cause a vuetify app to go "snakey" and exhibit strange behaviour like clicks not working in data tables, menus not dropping down on toolbar etc if the app happens to be not localhost or not https and so service worker can't operate.

Removing that line reliably fixes this problem but of course breaks the whole thing when service workers are supported; but it's a big issue in cases where users run the app locally on a private network as an option rather than hosted (for example).

I'm currently trying to figure out how to work around this, it's taking forever due to a slow build process and a phone as my only test device outside my localhost; I'm guessing there is a simple way to not call this by detecting if service worker is running but haven't go there yet.

You might consider adding a conditional to that line to fix this issue.
=-=-=-
UPDATE: well that was easy:

 if (navigator.serviceWorker) {
      navigator.serviceWorker.addEventListener("controllerchange", () => {
...etc...

Please consider updating your article and code (perhaps that guy who straight up copied your article will update his as well :) )

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.