5um17 / wp-extended-search Goto Github PK

Just wanted you to know that your recent update to 2.0 caused a bunch of errors to show up on the admin screen for users that do not have "manage_options" in their user role. Something in the constructor file you have that adds the wp-extended search to the menu nav vs in the previous versions you had it showing under the settings menu. I have a few users that only have the ability to view the sites current users and modify them, not allowing them to see settings and other menu items. The recent update was throwing like 6 fatal errors. I had to rollback the plugin to the previous version then all the errors went away.

When searching without a string in the input form, the results displayed are the default wordpress, this means that the plugin is useless in this situation. Is this a bug?

Hi,

When searching for keyword in a password protected article, if the person who searches it is not logged in, then the returned result will not contain articles that includes the tag or published by author.
Is this a bug?

Thank you!

Hi,

I'm testing a theme and a few plugins to make sure they work in WordPress 6.0 when it is released, but I keep running into the following error when doing a search with your plugin activated:

WordPress database error: [Unknown column 'estt.taxonomy' in 'where clause']
SELECT SQL_CALC_FOUND_ROWS wp_posts.ID FROM wp_posts WHERE 1=1 AND ( ((wp_posts.post_title LIKE '%testing%') OR (wp_posts.post_content LIKE '%testing%') OR (wp_posts.post_excerpt LIKE '%testing%') OR (estt.taxonomy = 'post_tag' AND est.name LIKE '%testing%'))) AND ((wp_posts.post_type = 'post' AND (wp_posts.post_status = 'publish' OR wp_posts.post_status = 'private')) OR (wp_posts.post_type = 'page' AND (wp_posts.post_status = 'publish' OR wp_posts.post_status = 'private'))) ORDER BY wp_posts.post_title LIKE '%testing%' DESC, wp_posts.post_date DESC LIMIT 0, 12

The error only appears when searching taxonomies is enabled.

The test environment is running the following:

• WordPress 6.0-RC1
• Twenty Twenty-Two Version 1.2 (theme)

Plugins:

• WP Extended Search Version 2.1.1
• Wordfence Security Version 7.5.9
• WordPress Beta Tester Version 3.2.1
• Force Login Version 5.6.3

On my production site running WordPress 5.9.3 with the same configuration (minus the WordPress Beta Tester plugin), this error does not occur... Please let me know if you need any more details.

Current implementation only search product category name. Please enable the search into the product category description when looking for post/product.

I am not a php or wordpress developer - so I don't really know how to properly test it with a php dev stack. So I just read the code and hacked it with one line change in the most recent release (2.1.1) and deployed the change directly to my site. If you would like me to do a pull request for this one-line change, I'd be happy to.

wp-extended-search/includes/class-wpes-core.php

diff --git a/includes/class-wpes-core.php b/includes/class-wpes-core.php
index ad4326c..5b5553c 100644
--- a/includes/class-wpes-core.php
+++ b/includes/class-wpes-core.php
@@ -425,7 +425,7 @@ final class WPES_Core {
 
                                        foreach ( $this->wpes_settings['taxonomies'] as $tax ) {
                                                $search .= $or . $tax_or;
-                                               $search .= $wpdb->prepare( '(estt.taxonomy = %s AND est.name LIKE %s)', $tax, $term );
+                                              $search .= $wpdb->prepare( '(estt.taxonomy = %s AND (est.name LIKE %s OR estt.description like %s))', $tax, $term, $term );
                                                $or      = '';
                                                $tax_or  = ' OR ';
                                        }

Problem Description

My Extended Search configs:

Solution

I ended up tracing the issue to /includes/class-wpes-core.php:283. That line didn't account for the possibility that the $_GET might be an array.

It was late and I ran out of debugging steam, but it wasn't working just using the array, but it worked by imploding it and then exploding it so I went with that.

I'm pretty new to Wordpress and I'm a bit unclear how I keep this change in my filesystem without it being overwritten every time there is an update so I'm hoping this issue flag can help lead to a long-term fix to the plugin. Super happy to help, hit me up if you have any questions.

Patch:

diff --git site/web/app/plugins/wp-extended-search/includes/class-wpes-core.php site/web/app/plugins/wp-extended-search/includes/class-wpes-core.php
index ad4326ca..9cdb5acf 100644
--- site/web/app/plugins/wp-extended-search/includes/class-wpes-core.php
+++ site/web/app/plugins/wp-extended-search/includes/class-wpes-core.php
@@ -283,8 +283,13 @@ final class WPES_Core {

      // Set post types.
      if ( ! empty( $this->wpes_settings['post_types'] ) ) {
-				if ( isset( $_GET['post_type'] ) && in_array( esc_attr( $_GET['post_type'] ), (array) $this->wpes_settings['post_types'], true ) ) {
-					$query->query_vars['post_type'] = (array) esc_attr( $_GET['post_type'] );
+				$attr =  isset($_GET['post_type']) ? $_GET['post_type'] : false;
+				$attr = is_array($attr) ? implode(',', $attr) : $attr;
+
+				if ( $attr && !is_array($attr) && in_array( esc_attr( $attr ), (array) $this->wpes_settings['post_types'], true ) ) {
+					$query->query_vars['post_type'] = (array) esc_attr( $attr );
+				} elseif ( $attr && is_string($attr) ) {
+					$query->query_vars['post_type'] = (array) explode(',', $attr);
        } else {
          $query->query_vars['post_type'] = (array) $this->wpes_settings['post_types'];
        }

I’m working on a woocommerce site. My WP Extended Search pluggin has these settings (https://ibb.co/f0XqPTF)

• optimized for products search
• select taxonomies: “product categories” and “product tags”
• select post types: products
• Terms relation type: AND

For the most part, it works well on combination of keywords from tag/category/description/title etc. However, say, a product has two tags: tag1 and tag2, and if I search for “tag1 tag2” the result would not return.

This is triggering the archive template even on single product query. Am I doing something wrong?

pre_get_posts hook is overriding the wp_query for other plugins & showing default posts instead of the actual post type list.

Please make it specific so it wouldn't impact for other plugins.

You can try Simple Job Board to reproduce the bug.