Comments (3)
aantron
commented on August 31, 2024
It looks like enum.h would have to be modified to support a definable macro, which is expanded either after the class keyword or before each of the members you would like to export. Which do you think is more appropriate?
The user would be able to do something like
#define BETTER_ENUMS_EXPORT __declspec(dllexport)
#include <enum.h>and either put that into a header file in their own project that they then include, or supply the definition on the command line.
If you would like to make a PR, I will be happy to review it.
from better-enums.
malkindan
commented on August 31, 2024
I personally would prefer whole class / struct to be exportable. How do I
ask for PR ?
…On Mar 27, 2017 9:13 PM, "Anton Bachin" ***@***.***> wrote:
It looks like enum.h would have to be modified to support a definable
macro, which is expanded either after the class keyword
<https://github.com/aantron/better-enums/blob/37d8f987ca939af846a2d29a8f8198f9bf3ac4b7/enum.h#L588>
or before each of the members you would like to export. Which do you think
is more appropriate?
The user would be able to do something like
#define BETTER_ENUMS_EXPORT __declspec(dllexport)
#include <enum.h>
and either put that into a header file in their own project that they then
include, or supply the definition on the command line.
If you would like to make a PR, I will be happy to review it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJwzf8Awk9HTJoFZlYS_iaS6G5w4QEShks5rp-jFgaJpZM4MqMMq>
.
from better-enums.
aantron
commented on August 31, 2024
Fork this repo, make your changes, push them to the fork, then click the "open pull request" button next to your branch. You may want to see this help page.
from better-enums.
Related Issues (20)
- Static functions for enum types HOT 1
- Use in a packed struct HOT 1
- MSVC /permissive- leads to "expression did not evaluate to a constant" HOT 3
- Compiling example code: 5-map.cc fail HOT 2
- enums stops being enums HOT 1
- What is the tool to run better-enums in REPL mode in README.md? HOT 2
- Compile-time name trimming and binary size
- How to reflect to enum with type and value strings？ HOT 4
- Need to have standard Debian packaging capability
- Cannot use better_enum from class HOT 1
- Using Better Enums in std::unordered_map as key leads to 'message : see reference to class template instantiation'
- Timeframe for new release / tag
- Provide an update to make_macros.py script to use python3
- Set up GitHub Actions
- C++17 interop: std::optional HOT 2
- Way to opt out of string conversion? HOT 2
- cannot add better_enum values to unordered_set HOT 3
- Member '_value' was not initialized in this constructor HOT 1
- Better-enum in maps HOT 7
- Are there guarantees on size with better enums? HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from better-enums.