Giter VIP home page Giter VIP logo

Comments (4)

ackwell avatar ackwell commented on August 31, 2024

I've added an option, noDefaultTags, which will stop it from using its default tags.

Hope that works for you!

(341825b)

from bboxed.

marksyzm avatar marksyzm commented on August 31, 2024

Oh brilliant! Thanks very much.

from bboxed.

marksyzm avatar marksyzm commented on August 31, 2024

@ackwell I might do a fork and chuck in a couple more things, because I'm actually writing forum software at the moment and this is the current better package out there from what I've seen!

The first one is that if you were to use this in a browser, the tags would still be required in the code which leaves unnecessary code in a bundle. We need either some sort of way to chuck an if statement around the require (which doesn't really work for browserify or webpack as they build via string replace) or we separate out the tags as an optional library that can be separately required. What do you think?

The other one is that typically with vBulletin and some other forums software, they use [list] tags that default to just using the word [list] for an unordered list, and you have the immediate tag value as either [list=1] or `[list=a] for an ordered numeric or alphabetical list. Do you want me to look into this one or do you think you could do that quickly yourself?

from bboxed.

ackwell avatar ackwell commented on August 31, 2024

Admittedly, the codebase was (despite intentions) never really optimised for browser-side usage - it's primary intended usage doesn't even support some of the tags it does have, so I never really got around to it. That said, I'm absolutely open to working on it a bit more.

The idea of splitting tags into a separate package is quite a good one, though the only issue I see it raising is potential backwards compatibility. I suppose it'd be easy enough to throw it out as v1 as per semantic versioning to indicate the API change.

And as for the list, it should be more than possible. I'll throw it in the issues as a to-do. I unfortunately won't have the time to really get into the codebase to make the required changes for a few days. Not sure what sort of schedule you're on, so if you're going to be implementing it, bung a message on the PR and I'll hold off.

from bboxed.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.