Comments (7)
@sirajyasin is working on this issue. i am not able to assign it to him. can some one help me in assigning this to him?
from airshipctl.
@sreejithpunnapuzha I'm unable to add him as well. I've done some digging into why this keeps happening, and it seems as though Github disallows assigning issues to arbitrary users to prevent abuse. In order to assign a user, that user must either have write permissions to the repo (as of now, I believe this is limited to WC and cores), or they must have left a comment on the issue.
@sirajyasin if you would like me to assign you to this issue, please leave a comment here.
from airshipctl.
@ian-howell , thanks for looking into the GitHub issue.
Yes, please assign it to me.
from airshipctl.
Related Change #713755
Subject: Organize CLI helper functions
Link: https://review.opendev.org/713755
Status: MERGED
Owner: Sirajudeen ([email protected])
Approvals
Code-Review
+2 Alexander Hughes
+2 Ian Howell
Verified
+2 Zuul
Workflow
+1 Ian Howell
Last Updated: 2020-04-22 16:45:08 CDT
from airshipctl.
Removed the cmds.go within config/ and added a helper for config ( config_helper.go ). If this approach is agreed, then we can create helpers for respective packages when required and have the additional validations or any kind of helper functions done there
PS for review in Gerrit
from airshipctl.
The commit is merged. So this issue can be marked closed. Going further i will follow the comment convention to auto close.
from airshipctl.
A [Related Change](https://review.opendev.org/778359 was merged. This issue may be ready to close.
from airshipctl.
Related Issues (20)
- Support multiple versions of clusterctl HOT 5
- AIAP: Document the requirements for the infrastructure builder image HOT 4
- AIAP: Create a multi-node `infra-builder` image HOT 3
- AIAP: Using the `.git` suffix on repository names causes runner pod failure HOT 2
- AIAP: support non test GPG keys HOT 5
- Provide Calico CNI IPv4/v6/Dual Stack Support in Airshipctl HOT 2
- AIAP : Support for DualStack IPv6 HOT 2
- Install latest docker version within build_gate.sh script HOT 1
- Enable extraction of target/workload cluster artifacts HOT 3
- AIAP: Shift gates to use AIAP HOT 3
- AIAP: Documentation redirect HOT 3
- source|target version replacement for qcow_bundle is missing. HOT 4
- AIAP : Add support for IPV6 infra to test Airship-in-a-pod in Zuul Gates HOT 2
- 10_build_gate.sh fails to locate ensure-docker ansible role HOT 3
- `make manifests` target doesn't work HOT 1
- Create zuul job which performs make generate/make manifests HOT 1
- Develop new kubeconfig workflow HOT 2
- Allow to resume phase plan execution from a certain phase HOT 2
- Fail to create kubeval-validator image. HOT 2
- namespace-v1.json is missing when running "airshipctl plan validate deploy-gating" HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from airshipctl.