Giter VIP home page Giter VIP logo

Comments (7)

sreejithpunnapuzha avatar sreejithpunnapuzha commented on September 28, 2024

@sirajyasin is working on this issue. i am not able to assign it to him. can some one help me in assigning this to him?

from airshipctl.

ian-howell avatar ian-howell commented on September 28, 2024

@sreejithpunnapuzha I'm unable to add him as well. I've done some digging into why this keeps happening, and it seems as though Github disallows assigning issues to arbitrary users to prevent abuse. In order to assign a user, that user must either have write permissions to the repo (as of now, I believe this is limited to WC and cores), or they must have left a comment on the issue.

@sirajyasin if you would like me to assign you to this issue, please leave a comment here.

from airshipctl.

sirajyasin avatar sirajyasin commented on September 28, 2024

@ian-howell , thanks for looking into the GitHub issue.
Yes, please assign it to me.

from airshipctl.

airshipbot avatar airshipbot commented on September 28, 2024

Related Change #713755

Subject: Organize CLI helper functions
Link: https://review.opendev.org/713755
Status: MERGED
Owner: Sirajudeen ([email protected])

Approvals

Code-Review
+2 Alexander Hughes
+2 Ian Howell
Verified
+2 Zuul
Workflow
+1 Ian Howell

Last Updated: 2020-04-22 16:45:08 CDT

from airshipctl.

sirajyasin avatar sirajyasin commented on September 28, 2024

Removed the cmds.go within config/ and added a helper for config ( config_helper.go ). If this approach is agreed, then we can create helpers for respective packages when required and have the additional validations or any kind of helper functions done there

PS for review in Gerrit

from airshipctl.

sirajyasin avatar sirajyasin commented on September 28, 2024

The commit is merged. So this issue can be marked closed. Going further i will follow the comment convention to auto close.

from airshipctl.

airshipbot avatar airshipbot commented on September 28, 2024

A [Related Change](https://review.opendev.org/778359 was merged. This issue may be ready to close.

from airshipctl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.