Link insertion doesn't work about trumbowyg HOT 5 CLOSED

I confirm the bug, but I don't know how to fix it right now :/

from trumbowyg.

Hello @Alex-D,

to let you know, same thing is happening while using IE v11.

I think that the problem is here with the browser difference about execCommand function and in particularly createLink command.

MDN docs says:

createLink
Creates an anchor link from the selection, only if there is a selection. This requires the HREF URI string to be passed in as a value argument. The URI must contain at least a single character, which may be a white space. (Internet Explorer will create a link with a null URI value.)

Here is a link to docs: https://developer.mozilla.org/en-US/docs/Web/API/document.execCommand

As a solution, maybe there is a way to create a workaround, which would insert some white spaces and perform range selection automatically before the actual link insertion? And then after that perform a white space cleanup?

Regards,
-Vytautas

from trumbowyg.

I can confirm that this happens in ie9 and ie8 (not surprisingly).

Additionally, on ie8, when you open the insertLink modal, it shows up:

Naturally, the [object TextRange] gets used as the text/alt if you don't change them.

from trumbowyg.

I think the solution may be similar to the solution for #58

from trumbowyg.

Fix thanks to @lizardK :)

from trumbowyg.