Keybindings override about omni HOT 11 CLOSED

If current tab has actions on keyboard (like escape key in telegram web) it overrides action in Omni, and Omni does not closing

Bro, just click outside the menu
It will exit

from omni.

Bro, just click outside the menu

I know, but there should be way to do it without mouse in that case

from omni.

Bro, just click outside the menu

I know, but there should be way to do it without mouse in that case

type something that gives 0 results [like hhhhhhhhhhhhhhh] and press enter

from omni.

I've been looking into this and honestly I haven't found a solution. I see on Telegram it requires pressing the Esc key two times to work, it can certainly be a bit annoying. Unsure if I can do anything about it, I considered making the Esc key an "official" command, but if you had an extension that was also using it that would cause issues. Would be interested to see if anyone knows how this could work - I'm assuming it's due to some event.stopPropagation() call?

from omni.

I've been looking into this and honestly I haven't found a solution. I see on Telegram it requires pressing the Esc key two times to work, it can certainly be a bit annoying. Unsure if I can do anything about it, I considered making the Esc key an "official" command, but if you had an extension that was also using it that would cause issues. Would be interested to see if anyone knows how this could work - I'm assuming it's due to some event.stopPropagation() call?

making an close Omni command will do right?

from omni.

I've been looking into this and honestly I haven't found a solution. I see on Telegram it requires pressing the Esc key two times to work, it can certainly be a bit annoying. Unsure if I can do anything about it, I considered making the Esc key an "official" command, but if you had an extension that was also using it that would cause issues. Would be interested to see if anyone knows how this could work - I'm assuming it's due to some event.stopPropagation() call?

making an close Omni command will do right?

Yes, closeOmni() makes the omnisearch close, the problem is how to make it trigger on the Esc key when Telegram seems to prevent it from propagating.

from omni.

Wont making an action close Omni that will call closeOmni() be acceptable?

from omni.

Or better, why not inject overide-hotkeys.js to the webpage while initiating omni ?

from omni.

Wont making an action close Omni that will call closeOmni() be acceptable?

No, there are many ways to close Omni already (clicking outside the omnisearch, pressing Esc, and pressing on the extension icon), and they all should work.

Or better, why not inject overide-hotkeys.js to the webpage while initiating omni ?

This wouldn't solve anything, the keypress event would still not propagate.

from omni.

overide-hotkeys.js

onkeydown = function(e){
  if(e.escKey.charCodeAt(0)){
    e.preventDefault();
  }
}

ig this would work

from omni.

onkeydown = function(e){
  if(e.escKey.charCodeAt(0)){
    e.preventDefault();
  }
}

Doesn't quite work, I ended up doing a different thing though and managed to fix it. A bit weird but basically listening for the keyup event outside jQuery did work, so I used that and then closed it through there.

from omni.