transpiler: fat arrow functions should become `() {}` about angular HOT 5 CLOSED

What about re-using the existing ArrowFunctionTransformer ?

from angular.

@vicb ArrowFunctionTransformer transforms () {} into a regular function like var _this = this; function() {};

I think the js2dart transpiler should NOT include ArrowFunctionTransformer - keep the arrow functions and dart writer will output them as () {} instead of () => {}.

from angular.

@vojtajina I think we are both right to some extent - being positive :)

We should not include the original ArrowFunctionTransformer as it renames this which is not required for Dart. However Dart => functions could only be composed of a single statement and always have an implicit return.

I think the way to go is to create a new transformer [based on ArrowFunctionTransformer] that only transform the concise body.

from angular.

More details:
In ES6, arrow functions have an implicit return if they are not defined with a function body:

// body -> no implicit return
var square = (x) => {
  return x * x;
};
// no fn body -> implicit return
var square2 = x => x * x;
var objectify = x => ({ value: x });

Whereas arrow functions in Dart are composed of a single statement & always have an implicit return.

What should be done:

• Fat arrow functions in JS need to be transpiled to () {} in Dart. (original issue),
• convertConciseBody

from angular.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

from angular.