[Feature request] Ability to prioritize certain attributes over keeping the selectors as short as possible. about finder HOT 5 OPEN

Plus 1 for this feature.

this would give the users the possibility to prioritize criteria.
maybe not just prioritizing certain attributes over other attributes, but maybe also lower the priority of class or tag-name over attributes in general or certain attributes like the mentioned data-testid.

Ps: we are using your library in Robot Framework Browser, which is a Playwright based library for Robot Framework. We added your lib in June 2021 and we are super happy about your contribution!
https://robotframework-browser.org/ 😉

from finder.

I’m thinking about the good API design for such feature.

@antonmedv how about a new option called as penalties with the type

type penalties = {
  idName?: (name: string) => number;
  attr?: (name: string, value: string) => number;
  className?: (name: string) => number;
  tagName?: (name: string) => number;
};

Or can change the type of the existing idName, className, tagName, attr properties to support a number output that can be the penalty value in addition to the existing boolean

export type Options = {
  idName: (name: string) => boolean | number
  className: (name: string) => boolean | number
  tagName: (name: string) => boolean | number
  attr: (name: string, value: string) => boolean | number
  ...
}

from finder.

Well, I guess something like a config for custom penalties can be added.

Currently, now all attr gets a penalty: 0.5.

from finder.

Well, I guess something like a config for custom penalties can be added.

Currently, now all attr gets a penalty: 0.5.

@antonmedv That would be a good idea. With that one can choose to give a negative penalty for any attribute that needs to be prioritised to generate more reliable selectors. For example, data-testid attributes.

from finder.

I’m thinking about the good API design for such feature.

from finder.