Giter VIP home page Giter VIP logo

Comments (2)

mzabriskie avatar mzabriskie commented on March 28, 2024

I am really frustrated with ES6 Promises. I was unfortunately unaware of the error swallowing behavior when I first started with axios, and thought that building on standardized, native Promises was the right thing. I am questioning that decision now.

I have thought a lot about what should be done, and have ultimately concluded that axios itself won't do anything to try and solve the problem. Instead I will let consumers decide how they want to handle it. Long term, browser dev tools should report an error when the Promise is garbage collected.

Until then I personally would consider using a polyfill for done, such as https://www.promisejs.org/polyfills/promise-done-6.1.0.js. I think that it's cleaner than doing the setTimeout yourself.

from axios.

ivan-kleshnin avatar ivan-kleshnin commented on March 28, 2024

@mzabriskie, thank you for this comprehensive answer!
I actually agree with your advice, and already made the same choice of polyfilling.

from axios.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.