Comments (5)
A PR to get started on would be great. And yes, that typo should be fixed :)
from domjson.
I made progress on this (see here: https://github.com/Hypercubed/domJSON/tree/refactor/build). I converted the source to CJS then using browserify (see package.json scripts
) to convert to UMD. Personally, these days, I prefer to use npm scripts to do the simple build steps (like browserify and uglify). However, it is easy enough to add browserify as a gulp step (see https://github.com/gulpjs/gulp/blob/master/docs/recipes/browserify-transforms.md).
I'm having some trouble with your building and testing setup. Your karma setup requires testing the UMD code which means you need to run tests after the conversion to UMD, but before your test-code
is removed. You can handle this a few ways... generating a temp UMD source for testing, put tests in-between browserify and gulp build
, or otherwise refactor your tests. I'm not sure what approach you would like to take for this.
from domjson.
Sorry, very pressed at work this week. I'll try and resolve this issue over the weekend.
from domjson.
Solved by #31
from domjson.
@azaslavsky Sorry for digging up an old issue. Can you please rebuild and publish a new version to npm. We are unable to test our application because of this error.
from domjson.
Related Issues (20)
- Create page and demos
- Add browser compatibility table to docs
- Create demos
- When serialProperties is not false, .toDOM() produces multiple copies
- Speed optimizations
- "The input element's type ('checkbox') does not support selection." HOT 2
- Missing computedStyle in `toDOM` HOT 2
- Getting the complete DOM HOT 4
- better reprasentation of json output HOT 1
- [question] How to pass pure html in toJSON() method? HOT 2
- Help guide has the wrong implementation of Node.replaceChild() HOT 1
- Usage w/ Jsdom: TypeError: Cannot read property 'href' of undefined HOT 12
- has some errors on NodeJS environment HOT 2
- Question about banned/disallowed tags HOT 9
- IE 11 InvalidStateError during copyJSON HOT 3
- I do not get instructions HOT 3
- Request to include xpath of the HTML element in the JSON
- How to handle DOM mutations?
- Cannot import this inside jest tests HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from domjson.