Giter VIP home page Giter VIP logo

Comments (3)

mikemcdonald avatar mikemcdonald commented on September 28, 2024 1

Personal preference is all caps and no spaces. Makes catching and using the errors in offchain components much easier to reason about when you don't have to think about case and spaces. I'd also consider prefacing everything with BAL or BALANCER so it is clear on complex txs on mainnet that touches many protocols where the revert is actually happening.

Ex:
BALANCER_CONTRACTNAME_ERRORTYPE_DETAILS

where ERRORTYPE could be something like MATH ACCESS VALIDATION SWAPS

IIRC the optimizer does actually save space on smaller revert reasons (even if its under 32 bytes)

from balancer-v2-monorepo.

nventuro avatar nventuro commented on September 28, 2024

Done already, we removed the ERR prefix.

from balancer-v2-monorepo.

nventuro avatar nventuro commented on September 28, 2024

Reopening this as we're once again introducing revert reasons to some contracts, as discussed in #583.

from balancer-v2-monorepo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.