Comments (3)
Personal preference is all caps and no spaces. Makes catching and using the errors in offchain components much easier to reason about when you don't have to think about case and spaces. I'd also consider prefacing everything with BAL
or BALANCER
so it is clear on complex txs on mainnet that touches many protocols where the revert is actually happening.
Ex:
BALANCER_CONTRACTNAME_ERRORTYPE_DETAILS
where ERRORTYPE
could be something like MATH
ACCESS
VALIDATION
SWAPS
IIRC the optimizer does actually save space on smaller revert reasons (even if its under 32 bytes)
from balancer-v2-monorepo.
Done already, we removed the ERR prefix.
from balancer-v2-monorepo.
Reopening this as we're once again introducing revert reasons to some contracts, as discussed in #583.
from balancer-v2-monorepo.
Related Issues (20)
- Add Avalanche root gauge
- Add Polygon ZK EVM root gauge
- Add Avalanche and Polygon ZK EVM as gauge types to checkpointer HOT 1
- Improve addresses JSON HOT 1
- `StableMath::_calculateInvariant` can, in fact, overflow HOT 3
- Redeploy batch relayer in L2s with reference to the pseudo minter HOT 1
- Allow a single gauge factory per gauge type in `GaugeAdder` HOT 1
- Remove `deployments/` package
- Address calling peekChainedReferenceValue in payable transactions
- Implement LZ bridge forwarder
- L2GaugeCheckpointer: fix checkpoint timestamp
- Develop new Avalanche root gauge for new LZ bridge HOT 1
- Adjust docs in CSP / `getRate`
- Seedless LBPs HOT 2
- ProtocolId Registry
- Develop Base root gauge factory
- BPT_IN_FOR_EXACT_TOKENS_OUT accuracy issue HOT 1
- Execution reverted: BAL#520 when calling joinPool on a Managed Pool to add ETH HOT 3
- Deployed npm packages are having missing files
- ComposableStablePoolFactory -> create error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from balancer-v2-monorepo.