Giter VIP home page Giter VIP logo

Comments (3)

bbottema avatar bbottema commented on September 27, 2024

Ok, so would you agree that it is harmless to provide logj properties or xml if it targets specific library packages? Because I was actually considering packaging 'sensible' default configurations for all major logging implementations and then let users override it with their own configuration.

What do you think?

from simple-java-mail.

james-m-henderson avatar james-m-henderson commented on September 27, 2024

I think the idea with libraries is generally that they can leverage slf4j or some other logging facade so that they don't need to provide any other logging dependencies.

The user of the library just includes the correct slf4j connector and configure their own logging as they need. If they need special logging levels from a library, they can just enable that in their local configuration file by enabling them for the package path for the classes in that library.

Sample log configurations could be provided, but I don't think that most people would use them. I definitely don't think they should be included in the standard packaging of the library.

A little bit of stackoverflow wisdom on this issue:

https://stackoverflow.com/questions/31138140/should-i-put-log4j-properties-file-into-library

http://stackoverflow.com/a/5081386/622115 (check the comments).

from simple-java-mail.

bbottema avatar bbottema commented on September 27, 2024

Agreed. I'll exclude the config files from the distributions.

I made everything related to logging test-scoped.

from simple-java-mail.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.