cassioneri / eaf Goto Github PK

Two related problems actually:

• setting CXX_STANDARD via GLOBAL PROPERTY doesn't seem to work on modern cmake versions(?)
• the latest versions of Boost.Math warn about an impending shift to C++14, which breaks the compile due to -Werror:

#    warning "The minimum language standard to use Boost.Math will be C++14 starting in July 2023 (Boost 1.82 release)"

The easiest fix is to just consider C++14 the new minimum version everywhere, and specify it using the the CMAKE_CXX_STANDARD setting (see https://cmake.org/cmake/help/latest/prop_tgt/CXX_STANDARD.html) instead of via properties:

index 954c62e..9d6f4ab 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -16,12 +16,11 @@ project(EAF VERSION 1.0
   LANGUAGES CXX
 )
 
+set(CMAKE_CXX_STANDARD 14)
 if (MSVC)
-  set_property(GLOBAL PROPERTY CXX_STANDARD 14)
   string(REGEX REPLACE "/W[0-4]" "/W4 /WX" CMAKE_CXX_FLAGS
     "${CMAKE_CXX_FLAGS}")
 else()
-  set_property(GLOBAL PROPERTY CXX_STANDARD 11)
   add_compile_options(-Wall -Wextra -Wpedantic -Werror)
 endif()

I think the recommended way of tweaking it on "modern" cmake is via the target-specific "features", i.e. for each executable you'd have...

target_link_libraries(to_date benchmark benchmark_main)
target_compile_features(to_date PRIVATE cxx_std_14)

...but for this simple use-case probably just setting a global CMAKE_CXX_STANDARD is good enough.

why don't you use uint32 or similar inthe struct and lay it out in little endian order (day, month, year) (eg, uint16, uint16, uint32 or uint8, uint8, uint16) then you can do a simple less/greater than to compare the dates?