Let's get CatBlock's options page translated!

僅限英文!

Please answer the following questions so that we can process your bug report, otherwise, we may have to ignore it.

Can you provide detailed steps on how to reproduce the problem?

1. browse this url
   https://share.dmhy.org/topics/list?keyword=%E5%BE%9E%E9%9B%B6%E9%96%8B%E5%A7%8B%E7%9A%84%E7%95%B0%E4%B8%96%E7%95%8C%E7%94%9F%E6%B4%BB&sort_id=0&team_id=407&order=date-desc
2. see the console, you will saw three error

What should happen when you do the above steps

What actually happened?
catblock/contentscript.js:115
el could be the document itself. and the document did not has width and height prop. causing javascript crash.

you could return undefined if the el is same as document.
this code could fix this
if (el == document) { return undefined; }

Do you have any other comments? If you can, can you please attach a screenshot of the bug?

--- The questions below are optional but VERY helpful. ---

If unchecking all filter lists fixes the problem, which one filterlist must you check to cause the problem again after another restart?

Technical Chrome users: Go to chrome://extensions ->Developer Mode -> Inspect views: background page -> Console. Paste the contents here:

Everything shows on one line instead of being formatted if opened in Notepad.

Currently, CatBlock replaces just ads, which were blocked and does not replace ads with cats, which are hidden (ads) by a stylesheet.

In Safari Technology Preview 11+, all parameters in Event.initEvent() are mandatory.

A regression of #66 has been identified, leading to not displaying replaced images of cats.

i try to use personalize filters and not working here, working on adblock u_u

In Manifest:

line 40: "bandaids.js". The path needs to be updated to "js/bandaids.js"

This was suggested by someone on Facebook. Change the word "Pause" to "Paws" in the options.

Would need to be only for the english version though, as the pun won't work in other languages.

in js/background.js:
line 1347: chrome.tabs.executeScript(tabId, {file: "ytchannel.js", runAt: "document_start"});

It should be js/ytchannel.js, else it is not working.

Right now, we are using AdBlock with CatBlock name,
but after a talk with @kpeckett we decided, that it we should use just CatBlock as an extension name instead.

blanket.js is refused to load, because of CSP for extensions.

Variable CATS is undefined in BG, because cats.js is not included in BG scripts.

@kpeckett In my opinion it would be better to change our version history.

Version 1.0 - Imported CatBlock to the repo
Version 1.1 (actually 2.8) - Included all changes needed for 2.8 release
Version 1.2 (actually 3.0) - Included changes for 3.0
..
..
..

What do you think? I think it does make sense, because it can be confusing that AdBlock is at 2.13.x now and we would release 2.8 and so on. Do you agree with this change?

Since AdBlock last changed the text for AdBlock button > Hide this button, Google have moved the URL for the extensions page back to chrome://extensions, rather than it being a part of the chrome://chrome page.

Looking at @byoogle's byoogle/port repository, we could switch out Michael's version for that, which might be useful if we need to do further work with other Chrome APIs.

As this is low priority, I will not assign it to a milestone.

The current design of Options page uses 3D styles for inputs, which are hard to style on Firefox and Edge browsers.

Also, the main panel for navigation takes a lot of space and could be further improved.

When I go to my student emails, hosted on Office 365 (outlook.office365.com) CatBlock is disabled on the page, and clicking "Enable CatBlock on this page" does nothing. It doesn't even refresh the page.

See gif:

After choosing, what ad should be blocked in the first step of "Block an ad" wizard, the wizard disappears.

This is a regression of #63.

With Cats from Catblock users and April fools off and only the flickr option on, it only loads 3 images
It appears it has a hard time parsing images a user. Which may be something to do with flickr.
Links tested:

• www.flickr.com/photos/sandiv999/ (3images)
• www.flickr.com/photos/wallacehenning (no images)

Tumblr / Imgur would be great.

Per James' request, I will try to make Project CATS mode working on Safari.

As reported on Tender:

Often an ad will be replaced three pictures that take more space than the original ad did

This is a legitimate concern, as they sometimes take up the entire screen (e.g. on nytimes.com).

Is there a way of adjusting the code to make a limit on the number showing, but still distributing the cats relatively evenly across the page?

These are non-blocking, but we have a few extraneous permissions in our manifest.

Opera warns that we are not using alarms and storage in our code, despite requesting permission for them.

Should we keep them in case we need them at a later time for their APIs to avoid a Chrome disable message?

Should this be in the menu or the options page?

For existing users, who have already upgraded to the latest 1.4.8, "Project CATS" mode will NOT be initialized.

$(window).load throws an error on Safari, looks like it is not supported anymore.
We should switch to $(window).on("load", function() { ... }); instead.

When using 1.4.9, I check the debug info and get the following:

=== Other Info ===
CatBlock version number: 1.4.9 Developer
UserAgent: Mozilla/5.0 (Windows NT 10.0 Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2873.0 Safari/537.36

String still says "AdBlock - click for details"

Usage of Shadow DOM API would give us an advantage in styling of our wizards and another advantage is that sites couldn't break them with theirs own CSS styles anymore.

@kpeckett

As of today, CatBlock installed via chrome://extensions page doesn't work with official AdBlock installed from Chrome Web Store.

The reason is: AdBlock has defined specific extension id, where sends messages about what selectors will be blocked on the page. When installing CatBlock from chrome://extensions page, CatBlock will get another unique specific ID, not the one we need.

Current work-around: Edit CatBlock's extension ID locally in adblock_start_chrome.js to the one from chrome://extensions

This is the current approach, however I'm not sure about long-time approach. We can either take a look at Chrome Management API, or release CatBlock on CWS and change unique ID in adblock_start_chrome.js OR pack AdBlock with Catblock for Chrome together (like we currently do with Safari version).

What do you think?

On YouTube, cats show up during the autoplay time window, pushing the image down and making the cancel button disappear.

Any way to fix this?

It loads at the bottom of the page with broken controls and no URL. Checkboxes on the page also turn into our theme until you close the popup.

Use for..of cycle in favour of iterating with for..in where applicable.

What can we do to fix this?

IndexedDB is intended to work with larger amount of data and would bring us higher performance, when loading/saving data for example filter lists.

http://support.catblock.tk/discussions/problems/16-title-for-chrome-extension-options-page-still-says-adblock-options

The title of the tab still says "AdBlock Options".

To reduce the number of users making issues with support requests, let's make a contributing file to warn them.

Adding this as the first line of a batch file will prevent all commands from displaying as if they were typed in manually.

As EasyList uses blocking rules as much as it can, we have very few cases where we can apply image replacement, as it currently only works with hiding rules. Is there any way we can expand to blocking rules as well? Perhaps changing where the ad is redirected to, rather than a blank page?

As reported, CatBlock will re-enable every disabled channel after a browser restart.

This is an unexpected behaviour and should be fixed as soon as possible

As this was a monthly contribution extension, we still have "are they donating" email checks available.

This needs removing.