cedargrovestudios / ad9833_featherwing Goto Github PK

hiya, we have a person who is using this library with issues
https://forums.adafruit.com/viewtopic.php?f=62&t=188798
and a few things would help debug the library:

• like other libraries that use SPI, you should not be creating the SPI device, it should be passed in as an argument
• instead of generating mpy's that will not stay up to date, submit the library to the bundle https://github.com/adafruit/CircuitPython_Community_Bundle and do proper releases on version changes

(we can help with both if you need)

I am running your driver "cedargrove_ad9833.py", not the "cedargrove_ad9833.mpy"

When running a simple test program, that just creates an AD9833 object, then sets the frequency to a fixed value and starts the wave generator, I get the following error.

Traceback (most recent call last):
File "main.py", line 21, in
File "cedargrove_ad9833.py", line 185, in update_freq
File "cedargrove_ad9833.py", line 226, in update_control_reg
AttributeError: 'AD9833' object has no attribute '_pause'

Examining the python source for the AD9833 class indicates that there is no attribute "self._pause"
Adding a line "self._pause = False" to the def init resolves everything.

I bought some AD9833 featherwing wave_generator boards from Oshpark, assembled one, and everything works as expected. Thanks for designing the board and driver code and releasing the information.
--- Graham

==