`lein marg` fails when a map value symbol contains a double colon about marginalia HOT 8 OPEN

I've literally never seen anyone name things with a colon in the middle. Thank you for the interesting case.
I'll put this on the roadmap for the 9.2 release

from marginalia.

Further investigation shows that it can handle vars with colons; it's maps with values that have colons in them that it chokes on:
This is fine: (def trouble:map {:foo "foo"})
This is not fine: (def trouble:map2 {:my-map trouble:map})

from marginalia.

I was able to make a minimal case for this one at the repl:
(require '[marginalia.parser :as p])
(p/parse "{:x y:z}") => Map literal must contain even number of forms

from marginalia.

Not sure why this works at the REPL:
(def my-reader (clojure.lang.LineNumberingPushbackReader. (java.io.BufferedReader. (java.io.StringReader. (str "{:f u:y}" "\n")))))
(. clojure.lang.LispReader (read my-reader false :_eof false))

because this is exactly what parse is doing when it throws the error
see: this code
https://github.com/gdeer81/marginalia/blob/b2d82b1c84bedc4fb89430cea374143c909249c0/src/marginalia/parser.clj#L437
https://github.com/gdeer81/marginalia/blob/b2d82b1c84bedc4fb89430cea374143c909249c0/src/marginalia/parser.clj#L438

gets called by this code to make a LineNumberingPushbackReader just like I did above https://github.com/gdeer81/marginalia/blob/b2d82b1c84bedc4fb89430cea374143c909249c0/src/marginalia/parser.clj#L440

Then this code calls parse* with that reader https://github.com/gdeer81/marginalia/blob/b2d82b1c84bedc4fb89430cea374143c909249c0/src/marginalia/parser.clj#L445

so (parse "{:foo x:y}") doesn't work but
(def my-reader (clojure.lang.LineNumberingPushbackReader. (java.io.BufferedReader. (java.io.StringReader. (str "{:f u:y}" "\n")))))
(. clojure.lang.LispReader (read my-reader false :_eof false)) or (parse* my-reader) works

from marginalia.

I'm running into this too.

While not super common, I've seen symbol names with colons in them in other projects. They're fairly common in Emacs Lisp, where they're often used either for namespacing or for a group of functions that do similar things. For example in emacs-rotate there's a series of functions like rotate:main-vertical and rotate:titled that all rotate your screen layout in different ways.

We're doing something similar in Metabase where we have two functions to fetch "Cards", one to fetch Cards for a Database and another for Cards for a Table. They're named cards:database and cards:table, respectively.

from marginalia.

I think #163 would help, just to join the dots here.

from marginalia.

Just a note that I experienced that issue while working on generating an XML for SAML with hiccup.
For example:

(hiccup/html
    [samlp:AuthnRequest
     {xmlns:samlp "urn:oasis:names:tc:SAML:2.0:protocol"
      :ID identifier
      :Version "2.0"
      :IssueInstant date
      :ProtocolBinding "urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST"
      :ProviderName sp-id
      :IsPassive false
      :Destination authorize-uri
      :AssertionConsumerServiceURL uri}
     [saml:Issuer
      {xmlns:saml "urn:oasis:names:tc:SAML:2.0:assertion"}
      uri]])

This is definitely happening because of the custom colon reader introduced in this 2011 commit that handles double-colon-namespaced keywords.

Looks like parser/read-keyword needs to be smarter, but I'm still thinking about how to do that.

from marginalia.