Giter VIP home page Giter VIP logo

Comments (6)

lefou avatar lefou commented on September 27, 2024 2

Right. So in other words, we've been using syntax that's no longer supported?

More the kind of: You used some code constructs which should never have compiled before, but somehow do. We try hard to make invalid thing not compile, which is not always possible with macros. So we catch those only by accident here. Meaning, defining a T should never be possible if you don't inherit Module.

from mill.

Gedochao avatar Gedochao commented on September 27, 2024 2

Managed to make it work, thanks for the tips!

from mill.

lihaoyi avatar lihaoyi commented on September 27, 2024 1

This looks like a code problem: you are defining a T.command inside the class TestHelper that does not extend mill.Module.

That is not expected to work I think: commands must be defined inside modules, and modules must be either traits or objects. Can you move the T.command out of the TestHelper class?

from mill.

Gedochao avatar Gedochao commented on September 27, 2024

Right. So in other words, we've been using syntax that's no longer supported?

from mill.

lefou avatar lefou commented on September 27, 2024

This looks like a code problem: you are defining a T.command inside the class TestHelper that does not extend mill.Module.

That is not expected to work: commands must be defined inside modules, and modules must be either traits or objects

Might be some copy and paste stuff, which I already fixed in scala-js-cli. VirtusLab/scala-js-cli#39

from mill.

Gedochao avatar Gedochao commented on September 27, 2024

@lefou right, thanks!
Lemme try to apply your fixes from scala-js-cli in scala-cli then

from mill.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.