Giter VIP home page Giter VIP logo

chemotion_saurus's People

Contributors

adambasha0 avatar allenskywalker92 avatar arooba-khokhar avatar baolanlequang avatar chrizzlegrazzl avatar cllde8 avatar dependabot[bot] avatar dianah583 avatar f-idiris avatar fabianmauz avatar fbroda avatar fthomas92 avatar github-actions[bot] avatar goofy39 avatar harivyasi avatar herrdivad avatar ira-maier avatar jancbrammer avatar jliermann avatar martinschae avatar mehmood86 avatar nicolejung avatar nishasharma14 avatar nrayya avatar patrickkit avatar phuang26 avatar pitrem avatar ptrxyz avatar rudori avatar tasnimmehzabin avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

chemotion_saurus's Issues

Remove versioning

As discussed, versioning adds complexity and we don't really need it.

Revision of test chapter

With the introduction of new test libraries and approaches, a revision of the test chapter is necessary.

Details modal: content to be added: datasets

In the details modal of samples, in the analyses tab, datasets window:
It would be great to provide some recommendation of the type of information to be added to the description field.

Create Development Chapter

explain stuff for development with chemotion ELN:

  • common errors
  • tools, VS extensions etc.
  • using Swagger for REST requests

Add ELN contributor guidelines

Suggestions so far:

  • commit title is meaningful => git history search
  • commit description is helpful => helps the reviewer to understand the changes
  • code is up-to-date with the latest developments of the target branch (rebased to it or whatever) => ⏩ :-merge for linear history is favored
  • added code is linted
  • tests are passing (at least locally)
  • if the changes are visible to the end-user, video or screenshots should be added to the PR => helps with user testing
  • testing coverage improvement is more than welcome
  • CHANGELOG : add a bullet point on top (optional: reference to github issue/PR )
  • clarify which dependencies are added, if any

Styleguide / Conventions

It would be great to agree on some conventions of writing and gather them in a document for all editors to be aware of. Possible areas:

  • Titles: All starts with capital letters or only first word?
  • Words in tables, do they start with capital letters?
  • Adding images before or after the corresponding paragraph?

Increase length of name_abbreviation in "Create new group"

When selecting My Groups -> Create new group in the field Name abbreviation there is a restriction to 2-5 characters. Attempts to enter longer acronyms (German: "Sigel") result in an error message:

name_abbreviation has to be 2 to 5 characters long

This can cause problems, as in our institute for example the NMR department uses by standard acronyms of the format AKX-YZ where X is the first letter of the family name of the PI and YZ are the initials of the corresponding group member. There are also other schemes which are even longer, as the YZ "name space" might easily run out of characters with very large groups.

As these schemes have been in place for a long time it will be very difficult to change them, especially when introducing an ELN institute-wide is already a major disturbance not necessarily appreciated by all long-term staff.

Is it possible to allow a couple of more characters, say 6-8???

Requirements for Documentation

We have identified the following minimum requirements for our documentation.

1. There should be specific docs for each version of the ELN

  • This is important especially w.r.t. installation instructions, since they have changed considerably throughout versions.
  • Legacy docs (i.e., not current version) won't be maintained and only receive critical updates (e.g., security)

2. We need to be able to edit the docs such that changes can be (selectively) made across different versions

- For example, if a change in v3 is benefecial to and also valid for v2 (but not v1), then it should be possible to only apply the changes to v2 and v3.

3. Users should be able to conveniently edit the current version of the docs

- How to ensure that non-functional edits (typos, style) to one version are propagated to other versions?

  • How to ensure that we do not clutter our git history with a bunch of minor edits?

4. Developers should be able to conveniently document (new) features

  • Ideally, we would like documenting and feature-development as closely coupled as possible.

5. Docs should be available offline

  • The offline docs would pertain only to the version that's currently running in the offline environment.
  • There should be a way to access the same documentation even if the ELN fails to run i.e. for troubleshooting scenarios.

6. Other related services need to be documented alongside the ELN

  • For example, we currently we need documentation for Repo, LabIMotion, ChemSpectra, CLI and ChemScanner.
  • We need to figure out how (and if) to integrate the documentation of these services into existing docs.

7. Provide roles for different types of readers of the docs

  • Structure docs along the lines of roles, such that it's easier for readers to find what matters to them:
    • developers
    • users
    • admins
    • contributors

πŸš€ CALL TO ACTION πŸš€
Please add additional requirements, remarks and/or suggest solutions as comments on this issue. When proposing solution(s), please clarify how the solution fulfills the above requirements. @harivyasi and I will integrate your contributions in the list above.

Rewrite Docker Installation Instructions

Status:
multiple instructions with overlapping content written by different authors available:
https://www.chemotion.net/chemotionsaurus/docs/eln/docker_installation (Peter Krauß) https://www.chemotion.net/chemotionsaurus/docs/eln/development_docker_installation (Aaroba Khokar)
https://www.chemotion.net/chemotionsaurus/docs/eln/DevDocker (Frank Broda)

TODOs:

Fix deploy job CI.

The deploy job fails intermittently with:

kex_exchange_identification: read: Connection reset by peer
rsync: connection unexpectedly closed (0 bytes received so far) [sender]
rsync error: unexplained error (code 255) at io.c(235) [sender=3.1.3]
Error: Process completed with exit code 255.

Respect user privacy

We need to work more towards respecting user privacy; especially when embedding items. Ideally loading any page of the documentation should not set any cookies without user permission.

search function not working

cause: error with Algolia configs, maybe index was reset by Algolia
dev + production mode
status: e-mail to Algolia support was sent, waiting for response

Create roles for documentation

optional: Due to the large growth of our documentation it would be helpful to create roles to highlight which part of the documentation is helpful to whom:
roles could be:

  • chemist
  • contributor (to the documentation)
  • developer (of docusaurus)
  • system admin or creator (of docusaurus)

Unclear documentation regarding SciFinder installation

The SciFinder module can be installed from Chemotion ELN plugin, please refer to the installation documentation. The function is currently available for members of Karlsruhe Institute of Technology only. A rework of the API to meet the requirement of SciFinderN will be provided as soon as possible.

Needs to be more specific / actionable.

Thanks for pointing this out @martinschae

Installation guide missing pieces

(comments from dd4d99b moved here for discussion/change request)

  • From how many users should I start splitting the services

  • How does this make sense? What advantages do I have?

  • Installation scripts for the different machines is missing.

  • On the end of the page are important information -> link possible?

  • How do I install Chemotion if several working groups at one university / from different universities want to access Chemotion? Does each working group have to install everything completely? Can I save the data of the working groups on different computers?

  • Where are the research data and entries stored in Chemotion? If the installation is done on multiple machines, Chemotion will have more users and consequently more data. Shouldn't the DB server have more hard disk or at least 500 GB?

  • The information density here is very high, and i think that single subheadings would help, e.g. "Use of SSL" here.
    Another point, e.g. Use of a server name

Markdown Linting

  • spell-checker
  • check for broken links
  • enforce line breaks in order to make files easier to work with in editor (i.e., no horizontal scrolling)

Suggestion: usage of hyperlinks whenever possible

At the moment, links are mostly used in the documentation to refer to other chapters when more details are needed. An improvement would be to replace each word described by a chapter or a paragraph by the corresponding link.

Search docs for WIP comments.

The docs contain some loose ends (unfinished sections etc.), some of them are marked with comments such as TO DO, #TODO or To be continued....

  • make overview of looses ends
  • figure out who can finish WIP sections

Rework Sidebar

As suggested by @nicolejung, the sidebar can be more intuitive, especially for the repo section. This issue tracks the progress in this direction.

subpages realoding/bookmarks

issue: subpages cannot be accessed via bookmark or reloading
intermediate solution until bug is fixed: go to root page (chemotion.net) again & click to subpage

load_sub_page.mp4

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.