Issue with naming of token and tokenValue parameter about cooptilleulsforgotpasswordbundle HOT 6 CLOSED

Hi @Cruiser13,

Thanks for opening this ticket. Could you open a PR to fix it please?

from cooptilleulsforgotpasswordbundle.

After investigation, it's totally normal to have a tokenValue as a request attribute, because the token request attribute is built from the RequestEventListener. This naming prevents erasing the original attribute.

The issue was on the OpenApiFactory parameter declaration, it should be tokenValue instead of token.

But I don't understand how you got a 404 while calling this route. Can you provide more context please @Cruiser13?

from cooptilleulsforgotpasswordbundle.

@vincentchalamon the open api docs (and the client generator of api platform) will not replace tokenValue in the request url as token is requested and not tokenValue. This leads to a request of /forgot_password/{tokenValue}?token=sometoken which will trigger a 404 since the route /forgot_password/{tokenValue} does not exist. I hope that has been a better explanation?

from cooptilleulsforgotpasswordbundle.

Can you try replacing 'token' by 'tokenValue' in the OpenApiFactory to check if it solves your issue please?

from cooptilleulsforgotpasswordbundle.

@vincentchalamon that would work the same way. That's the reason I asked wether I should be renaming all instances of token to tokenValue or the other way around in the first place :-)

from cooptilleulsforgotpasswordbundle.

OK I misunderstood the original issue, my bad!
The parameter name must be tokenValue. The token parameter is just for internal usage as a PasswordToken object retrieved from the token value.

from cooptilleulsforgotpasswordbundle.