Giter VIP home page Giter VIP logo

token-lists's People

Contributors

0xbutterfield avatar ahhda avatar alfetopito avatar anxolin avatar cmagan avatar eip-achilles avatar fedgiac avatar felix0x avatar fleupold avatar github-actions[bot] avatar imimim-username avatar mateipopa avatar nenadv91 avatar shoom3301 avatar sumpg41 avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

token-lists's Issues

[RemoveToken] `USDC` on `NETWORK`

Network

MAINNET

Address

0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48

Reason

Removing test etc etc

What about nested markdown?

hello!?!

Can I tag people here? Will it tag people again?
@alfetopito hey

const code = 'asdasdas'

No validation for fields on the Add tokens form

Discussed in https://cowservices.slack.com/archives/C0361CDG8GP/p1677685164664449
and in https://cowservices.slack.com/archives/C04DV3TL1MH/p1677685185496629

  1. Open Add token form from here https://github.com/cowprotocol/token-lists/issues/new/choose
  2. Fill in the fields with completely invalid data and submit the request
  3. Check the flow

AR: the request is successfully created. And add token PR is successfully created (#92).

ER: 2 options:

  1. add validation on the add token form to each field
  2. Auto-decline PR creation when any data is invalid on the form.

No validation on removeToken form

There is no validation for fields on the Remove token form:

  1. Instead of the address I can fill in anything I want, even 1 space is enough. It would be great to add validation ad least on an address format
  2. There is no validation for presence of an address on the List (I think, it is nice to have)
  3. There is no validation if an address belongs to a selected network or not (see #102)

[RemoveToken] `SYMBOL` on `NETWORK`

Network

MAINNET

Address

0x0000000000085d4780B73119b644AE5ecd22b376

Reason

I'm not sure that token in in our list....

test markdown

test inner code string
will it break???

Major version bump when token address changes

Summary

We must make sure to do a MAJOR version bump when any token address in the list changes

See this PR for reference #46

Add a linter and/or a GH action step to prevent merges/deployments in that case

[RemoveToken] Test test bla bla

Network

MAINNET

Address

0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48

Reason

Removing test etc etc

What about nested markdown?

hello!?!

Can I tag people here? Will it tag people again?
@alfetopito hey

const code = 'asdasdas'

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.