Giter VIP home page Giter VIP logo

Comments (3)

crsh avatar crsh commented on September 27, 2024 1

Hi, thanks for the feedback. I'm all for supporting your citation key format and I think allowing users to specify custom regex is a great idea! I added the regex in question in response to this issue: #49 Regrettably, it seems I did not implement the problematic keys as unit tests. So as a strategy for a PR, I think it would be great to first create a Rmd file containing a range of different test cases and then adjusting the regex to ensure it catches all cases. This would inform us, about whether the regex you suggest preserves the current functionality and adds the desired flexibility.

from citr.

ilsePit avatar ilsePit commented on September 27, 2024

suggested regex as default: "@[^(.|;|,|?|!)\\s\\]\)]+" , adjusted from line 47.

from citr.

ilsePit avatar ilsePit commented on September 27, 2024

Not sure I know exactly what you mean, I'm quite new to sharing code, so forgive me for asking rudimentary questions :). i understand making an Rmd and bib with a ton of different keys would be helpful in figuring out the best regex, but would you want me to push these to this repository? Or is there another way to do this (collaboratively) without adding those files to this repo? I can also do the test locally and then push once I find the Ultimate Regex (if that exists).
Thanks!

from citr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.