Giter VIP home page Giter VIP logo

rtypes's People

Contributors

d2km avatar ktec avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

Forkers

s-you ktec

rtypes's Issues

Annotated types

Hi, firstly thanks for an excellent library!

I have discovered that annotated types are not validated by the checker correctly.

I have reduced it down to the following test:

type = {:ann_type, 0, [{:var, 0, :annotation}, {:atom, 0, :atom}]}
term = :atom

typespec = Code.Typespec.type_to_quoted(type) |> Macro.to_string()

assert typespec == "ann_type(annotation, :atom) :: 0"
assert RTypes.Checker.check(term, type) == :ok

=> {:error, [term: :atom, message: "term does not conform to type", types: [{:ann_type, 0, [{:var, 0, :annotation}, {:atom, 0, :atom}]}], ctx: []]}

I'm happy to attempt a fix, but I wanted to check [sic] whether adding another function head to checker.ex is the right approach. Something like this:

  ## annotations
  defp check(term, {:ann_type, _, [{:var, _, annotation}, typ]}, ctx) do
    case check(term, typ, ctx) do
      :ok ->
        :ok

      {:error, _} ->
        {:error,
         term: term,
         message: "term does not match annotated #{annotation} type",
         types: [typ],
         ctx: ctx}
    end
  end

I've got this in a branch, if you're happy with it, or have suggestions to improve?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.