Giter VIP home page Giter VIP logo

Comments (7)

sam0x17 avatar sam0x17 commented on September 29, 2024 3

update: here is my fork, where I am attempting to try some things to fix this

https://github.com/sam0x17/mongo.cr

from mongo.cr.

sam0x17 avatar sam0x17 commented on September 29, 2024

Note that I have been unable to fix that last bug -- any help would be greatly appreciated

from mongo.cr.

sam0x17 avatar sam0x17 commented on September 29, 2024

@datanoise any headway on this?

from mongo.cr.

watzon avatar watzon commented on September 29, 2024

I fixed the last broken spec on your fork @sam0x17, as soon as my PR gets merged you should be able to PR here

from mongo.cr.

sam0x17 avatar sam0x17 commented on September 29, 2024

Looks like I'm still getting the same errors with those changes. Are you sure you are using Crystal 0.24.1?

Failures:

  1) Mongo::Uri should be able to create new uri
     Failure/Error: host.port.should eq(27017)

       Expected: 27017
            got: 0_u16

     # spec/uri_spec.cr:10

  2) Mongo::Uri should work with various ports
     Failure/Error: host.port.should eq(1443)

       Expected: 1443
            got: 0_u16

     # spec/uri_spec.cr:18

  3) Mongo::Uri should be able to create new uri with host and port
     Failure/Error: host.port.should eq(27017)

       Expected: 27017
            got: 0_u16

     # spec/uri_spec.cr:26

Finished in 879.77 milliseconds
75 examples, 3 failures, 0 errors, 0 pending

Failed examples:

crystal spec spec/uri_spec.cr:5 # Mongo::Uri should be able to create new uri
crystal spec spec/uri_spec.cr:13 # Mongo::Uri should work with various ports
crystal spec spec/uri_spec.cr:21 # Mongo::Uri should be able to create new uri with host and port

Out of curiosity what version of mongodb are you using @watzon? Looks like I have:

$ mongod --version
db version v3.4.10
git version: 078f28920cb24de0dd479b5ea6c66c644f6326e9
OpenSSL version: OpenSSL 1.0.2g  1 Mar 2016
allocator: tcmalloc
modules: none
build environment:
    distmod: ubuntu1604
    distarch: x86_64
    target_arch: x86_64

from mongo.cr.

watzon avatar watzon commented on September 29, 2024

Here's Crystal

➜ crystal -v
Crystal 0.24.1 (2017-12-20)

LLVM: 5.0.0
Default target: x86_64-unknown-linux-gnu

and mongo

➜ mongod --version
db version v3.6.2
git version: 489d177dbd0f0420a8ca04d39fd78d0a2c539420
OpenSSL version: OpenSSL 1.1.0g  2 Nov 2017
allocator: tcmalloc
modules: none
build environment:
    distarch: x86_64
    target_arch: x86_64

Looks like my mongo version is newer, but all the specs are passing for me.

from mongo.cr.

sam0x17 avatar sam0x17 commented on September 29, 2024

I will try with newer mongo and if that works I will merge

from mongo.cr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.