Giter VIP home page Giter VIP logo

Comments (7)

nhagen avatar nhagen commented on March 29, 2024

I think another options (which requires the most effort...) is to provide support out of the box for non-js assets and provide some documentation on how to remove them. I think a common reason for someone to use a starter kit is because they tried to configure everything independently and didn't get it quite right, so they went to the kit that had everything they needed. If you're unfamiliar with webpack, for example, its probably easier to strip stuff out than to add stuff. This is especially true if the ecosystem is new and you don't even know what you need.

from react-redux-starter-kit.

dvdzkwsk avatar dvdzkwsk commented on March 29, 2024

@nhagen I agree that would be nice, but the question is more about whether or not the starter kit should focus on a well-rounded development environment for client code or a more cohesive client+server kit. A lot of the features this starter kit uses are Webpack-specific (aliases, non-JS imports, etc.), so if we want to support them at all (whether or not we document how to remove them) that means the server code must either be bundled with Webpack, or use a Webpack'd application bundle (which is what it currently does).

From what you say, I'm leaning more towards keeping the server separated from the application source code, that way the starter kit can provide more options to those who, as you say, may not know how to configure it themselves. If the starter kit stays how it is, I'll definitely work on improving the documentation as you suggested.

from react-redux-starter-kit.

mlusetti avatar mlusetti commented on March 29, 2024

I totally agree on keeping the server separate and I actually like more the support for client-side development.
An universal kit is something everyone will strive to but to achieve it you've to be more opinionated.
I find perfectly suitable to have a webpack'd application bundle.

from react-redux-starter-kit.

tsemerad avatar tsemerad commented on March 29, 2024

I vote for keeping it how it is, but adding documentation on trimming out support for non-JS assets as @nhagen suggested. I may be a bit biased though - this starter kit has exactly what I need for my next project. Thank you for your work on it.

from react-redux-starter-kit.

dvdzkwsk avatar dvdzkwsk commented on March 29, 2024

Thanks @mlusetti and @tsemerad. I was leaning toward removing non-js assets just because a majority of the issues reported relate to server side rendering, but as @mlusetti said improving this aspect means implementing an opinionated build system. From what you guys say it sounds like the current configuration works well for most use cases, so I'll keep it how it is. This being the case, I'll work on improving documentation per suggestions and possibly add support for additional asset types.

Thanks for your help. I'll keep the ticket open just in case somebody else has an opinion, but the decision has essentially been made.

from react-redux-starter-kit.

mlusetti avatar mlusetti commented on March 29, 2024

You're doing a great job! Thank you so much for your effort, is really appreciated.

from react-redux-starter-kit.

dvdzkwsk avatar dvdzkwsk commented on March 29, 2024

Closing this since the server is no more.

from react-redux-starter-kit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.