Comments (9)
ooper-zz
commented on September 29, 2024
1
I will be working on this fix and send a PR when I am done.
from wyldcard.
ooper-zz
commented on September 29, 2024
Quick update. I got this functionality working. I will finish the test and the PR Friday (tomorrow for me).
from wyldcard.
ooper-zz
commented on September 29, 2024
I submitted a Pull Request
from wyldcard.
defano
commented on September 29, 2024
Thanks, @ooper-zz . I left you a review comment—I think the implementation for the clickLine can be simplified. Take a look and let me know if you disagree.
from wyldcard.
ooper-zz
commented on September 29, 2024
Sorry, it's probably me learning Github, but I can't find your review comments for the pull request on pull #113. I am looking at the Conversation tab for it and see 0 🧐
…Sent from my iPhone
On May 31, 2022, at 7:41 PM, Matt DeFano ***@***.***> wrote:
Thanks, @ooper-zz<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fooper-zz&data=05%7C01%7C%7C0c1a7a5d50af41508f5e08da4378389f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637896480871770154%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=TSplip8Jy9%2FnUtukqlIYlbqfvI5lWFw9oWASkjWFSjM%3D&reserved=0> . I left you a review comment—I think the implementation for the clickLine can be simplified. Take a look and let me know if you disagree.
—
Reply to this email directly, view it on GitHub<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdefano%2Fwyldcard%2Fissues%2F106%23issuecomment-1143056892&data=05%7C01%7C%7C0c1a7a5d50af41508f5e08da4378389f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637896480871770154%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VTBJE1UfFXSgPfzUG9Sqs%2FzD%2BVwXj9qynqmgsAxJPWE%3D&reserved=0>, or unsubscribe<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAZ473XFS6VSNTJYGSGIUQLVM3EVJANCNFSM5W3XP3UQ&data=05%7C01%7C%7C0c1a7a5d50af41508f5e08da4378389f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637896480871770154%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=IRDGYQARdVmL2fkhgjxjstbK3X4uAWX%2FgOMw1n5iVhY%3D&reserved=0>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
from wyldcard.
ooper-zz
commented on September 29, 2024
Hey @defano, I'm sorry, I can't find the PR review comment and what the simplification should be :( If you could add a link to this thread, It would be great and highly appreciated. Thanks!
At any rate, I am on vacation and will be until the latter part of week of June 13.
from wyldcard.
defano
commented on September 29, 2024
Hi @ooper-zz , try now—I think I forgot to "submit" the review back to you. Enjoy your vacation!
from wyldcard.
ooper-zz
commented on September 29, 2024
Thanks @defano, we did!
I submitted the changes you suggested. Best approach, for sure.
Take care.
from wyldcard.
defano
commented on September 29, 2024
Awesome—thanks, @ooper-zz. I have merged your changes.
from wyldcard.
Related Issues (20)
- HC executable Virus alert: my downloaded/installed version of HyperCard 2.4 running in the emulator has a virus
- feature: stacksInUse missing
- Documentation: FontExists is an XFCN built into the home stack out of the box, but it's not in the language or supported by WyldCard
- Bug (high priority): WyldCard hanging upon closing a stack that had script errors
- missing functionality and scripting:Scripting and Menu items for "Picture" are missing in Edit Menu
- Bug-med-priority: Undo in the script editor clears the whole script HOT 2
- Bug-Behavior compatibility, low: Command "f" does not type "find" into message box HOT 1
- security: WyldCard stacks should be better secured against hacking
- closeField event doesn't seem to trigger on a field HOT 1
- missing UI functionality: Option-click drag doesn't duplicate Parts HOT 3
- Plugin with id 'io.github.fvarrui.javapackager.plugin' not found HOT 3
- many POMs seem to have vanished HOT 2
- Not Saving Stacks HOT 3
- WyldCard does not send CloseField messages and moves the cursor to the next text field when user presses a tab on a text field HOT 2
- Undo/Redo Text is not working on text fields
- FatBits (pixel-edit) mode?
- Gradle. (7.6) "RepositoryHandler.jcenter" deprecated - what and *where* to change? HOT 2
- feature:Inferring UI from a chatGPT prompt HOT 1
- Exception when copying a field, something to do with protected field not made accessible ( HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wyldcard.