demkom58 / divinedrop Goto Github PK

Hi.
I tried to find which requirements are needed for building this project but failed, as I'm no programmer and are even completely new to gradlew.
Could you add a short explanation how we could build our own version of DivineDrop, so we have a good start for changing things?
Thanks :)

Currently 3DItems works great and DivineDrop is working however the name keeps dropping through the ground & disappearing when using both together
Screenshot of issue:

What do I want?: Well either compatibility with it or add this as a feature to divine drop.

Hello, can you add support for AuctionMasterItemDisplay? (https://www.spigotmc.org/resources/79002)
This plugin drops item for displaying auctions, and this items have AuctionMasterItemDisplay lore. You can just check to lore & content and block, thanks.

Logs: https://pastebin.com/YAcVXyTW
Details: Plugin don't work ??

version 1.19.2

Describe the bug
Potions are not getting stacked

To Reproduce
Steps to reproduce the behavior:

1. Drop same potions on ground

Expected behavior
Same potions gets stacked

Screenshots

Plugin (please complete the following information):

• Version 2.15
• Configuration config.txt

Server (please complete the following information):

• Core: Paper
• Version: 1.20.4

Server Core: Mohist-1.20.1
I can't use the language file "zh_CN"
If I change the config language option to "zh_CN"
The plugin will be disabled.
Here is a error from console:

[17:07:49 ERROR]: Error occurred while enabling DivineDrop v2.15 (Is it up to date?)
com.google.gson.JsonSyntaxException: com.google.gson.stream.MalformedJsonException: Invalid escape sequence at line 5579 column 60 path $.
at com.google.gson.Gson.fromJson(Gson.java:1229) ~[gson-2.10.jar%23152!/:?]
at com.google.gson.Gson.fromJson(Gson.java:1173) ~[gson-2.10.jar%23152!/:?]
at com.demkom58.divinedrop.version.V13R1.V13LangParser.parseLang(V13LangParser.java:19) ~[?:?]
at com.demkom58.divinedrop.version.V13R1.V13ResourceClient.parseLang(V13ResourceClient.java:25) ~[?:?]
at com.demkom58.divinedrop.lang.Language.updateLangMap(Language.java:37) ~[?:?]
at com.demkom58.divinedrop.lang.LangManager.manageLang(LangManager.java:57) ~[?:?]
at com.demkom58.divinedrop.DivineDrop.loadConfig(DivineDrop.java:94) ~[?:?]
at com.demkom58.divinedrop.DivineDrop.reloadPlugin(DivineDrop.java:84) ~[?:?]
at com.demkom58.divinedrop.DivineDrop.onEnable(DivineDrop.java:66) ~[?:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:347) ~[forge-1.20.1-47.3.4-universal.jar%23257!/:?]
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:336) ~[forge-1.20.1-47.3.4-universal.jar%23257!/:?]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:482) ~[forge-1.20.1-47.3.4-universal.jar%23257!/:?]
at com.rylinaux.plugman.util.PluginUtil.load(PluginUtil.java:366) ~[?:?]
at com.rylinaux.plugman.util.PluginUtil.load(PluginUtil.java:318) ~[?:?]
at com.rylinaux.plugman.util.PluginUtil.reload(PluginUtil.java:380) ~[?:?]
at com.rylinaux.plugman.command.ReloadCommand.execute(ReloadCommand.java:122) ~[?:?]
at com.rylinaux.plugman.PlugManCommandHandler.onCommand(PlugManCommandHandler.java:95) ~[?:?]
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46) ~[forge-1.20.1-47.3.4-universal.jar%23257!/:?]
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:147) ~[forge-1.20.1-47.3.4-universal.jar%23257!/:?]
at org.bukkit.craftbukkit.v1_20_R1.CraftServer.dispatchCommand(CraftServer.java:883) ~[forge-1.20.1-47.3.4-universal.jar%23257!/:997de31d-ddc9a2dad-d2eba2c8-47.1.105]
at org.bukkit.craftbukkit.v1_20_R1.CraftServer.dispatchServerCommand(CraftServer.java:867) ~[forge-1.20.1-47.3.4-universal.jar%23257!/:997de31d-ddc9a2dad-d2eba2c8-47.1.105]
at net.minecraft.server.dedicated.DedicatedServer.m_139665_(DedicatedServer.java:372) ~[server-1.20.1-20230612.114412-srg.jar%23252!/:?]
at net.minecraft.server.dedicated.DedicatedServer.m_5703_(DedicatedServer.java:350) ~[server-1.20.1-20230612.114412-srg.jar%23252!/:?]
at net.minecraft.server.MinecraftServer.m_5705_(MinecraftServer.java:1074) ~[server-1.20.1-20230612.114412-srg.jar%23252!/:?]
at net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:904) ~[server-1.20.1-20230612.114412-srg.jar%23252!/:?]
at net.minecraft.server.MinecraftServer.m_206580_(MinecraftServer.java:281) ~[server-1.20.1-20230612.114412-srg.jar%23252!/:?]
at java.lang.Thread.run(Thread.java:833) [?:?]
Caused by: com.google.gson.stream.MalformedJsonException: Invalid escape sequence at line 5579 column 60 path $.
at com.google.gson.stream.JsonReader.syntaxError(JsonReader.java:1657) ~[gson-2.10.jar%23152!/:?]
at com.google.gson.stream.JsonReader.readEscapeCharacter(JsonReader.java:1648) ~[gson-2.10.jar%23152!/:?]
at com.google.gson.stream.JsonReader.nextQuotedValue(JsonReader.java:1025) ~[gson-2.10.jar%23152!/:?]
at com.google.gson.stream.JsonReader.nextString(JsonReader.java:824) ~[gson-2.10.jar%23152!/:?]
at com.google.gson.internal.bind.ObjectTypeAdapter.readTerminal(ObjectTypeAdapter.java:95) ~[gson-2.10.jar%23152!/:?]
at com.google.gson.internal.bind.ObjectTypeAdapter.read(ObjectTypeAdapter.java:116) ~[gson-2.10.jar%23152!/:?]
at com.google.gson.internal.bind.TypeAdapterRuntimeTypeWrapper.read(TypeAdapterRuntimeTypeWrapper.java:40) ~[gson-2.10.jar%23152!/:?]
at com.google.gson.internal.bind.MapTypeAdapterFactory$Adapter.read(MapTypeAdapterFactory.java:186) ~[gson-2.10.jar%23152!/:?]
at com.google.gson.internal.bind.MapTypeAdapterFactory$Adapter.read(MapTypeAdapterFactory.java:144) ~[gson-2.10.jar%23152!/:?]
at com.google.gson.Gson.fromJson(Gson.java:1214) ~[gson-2.10.jar%23152!/:?]
... 26 more

Describe the solution you'd like
A clear and concise description of what you want to happen.

• a setting to set the item stack limit would be nice, like may stack items on the ground to 35x or 500x at least something that enables stacking over the standard limit.
• a setting so you can enable "no item movement", item should be on the spot when throwing more items in it. (also a extra setting for it something like, don't add it to the stack when sneaking while throwing)
• a setting for villagers, if a villager drops some potatos, those should not get stacked in a 2 blocks range, or if there is a wall~ maybe its possible with the server settings im gonna look..
  (idk if i should open each request in a new issue, if i should do so i do it)

Additional context
Add any other context or screenshots about the feature request here.
would nice to hear your opinon about those features ^^ and if you may gonna add them <3

Currently only common metrics are collected. To improve quality of features and understanding of community we need collect more detailed statistics.

So we shoud collect next common metrics:

1. selected language (config.yml > lang)
   Chart: Simple Pie; ID: config_language; Values: lower case lang code;
2. shift item pickup (config.yml > pickup-items-on-sneak)
   Chart: Simple Pie; ID: config_shift_pickup; Values: Enabled, Disabled;

Also metrics related drop-cleaner feature:

1. drop cleaner (config.yml > drop-cleaner.enabled)
   Chart: Simple Pie; ID: config_drop_remover; Values: Enabled, Disabled;
2. custom countdowns (config.yml > drop-cleaner.enable-custom-countdowns)
   Chart: Simple Pie; ID: config_custom_countdowns; Values: Enabled, Disabled;
3. death drop saver (config.yml > save-player-dropped-items)
   Chart: Simple Pie; ID: config_death_drop_saving; Values: Enabled, Disabled;
4. timer on load (config.yml > timer-for-loaded-items)
   Chart: Simple Pie; ID: config_timer_on_load; Values: Enabled, Disabled;

Case is sensetive for all values.

1.18 update

Describe the solution you'd like

1. Do not allow to pick up the item dropped by the death of players / mobs from plugins MythicMobs or EliteMobs to everyone except those who killed;
2. add a new owner placeholder: %drop_receiver_name%, %drop_receiver_displayname%, %drop_protection_time%;
3. protection should be only applied to players that have permissions divinedrop.drop-protect.player-death, divinedrop.drop-protect.mob-death and bypass permission divinedrop.drop-protect.bypass;
4. configuration structure:

drop-protection:
  # Protection time in seconds
  time: 540
  # If enabled, only killer of the player will be only able to get that drop during protection time
  player: false
  mob:
    vanilla: false
    mythicmobs: false
    elitemobs: false

Additional context
Reference: Baksovic's RPG Drop

i want to use rgb color with hex code
like &#fffffffHello

Describe the bug

• Plugin doesn't work on Purpur 1.18.2

To Reproduce
Steps to reproduce the behavior:

1. Install the Purpur 1.18.2 core
2. Install the latest version of DD
3. Check if it works with /dd command or just drop an item from your inventory.

Expected behavior

• Everything will work as shown on the main plugin page at spigotmc.org.

Screenshots

Plugin:

• Version: Tested on 2.7.4, 2.7.6, 2.7.7.
• Configuration: Has not been changed in any way.

Server:

• Core: Purpur.
• Version: 1.18.2

Describe the bug
A entity, for example piglin, picked up a gold ingot from the ground, the amount showed on item is still the original amount
Like 64 -> 64

To Reproduce
Just like above

Expected behavior
update the amount showed

Screenshots

Plugin (please complete the following information):

• version: 2.14

Server (please complete the following information):

• Core: paper
• Version: 1.20.4

Additional context
nope

Describe the bug
the item name is the full data name

Expected behavior
to show just the item name

Screenshots

Plugin (please complete the following information):

• Version 2.9
• Configuration https://pastebin.com/qMzWATEq

Server (please complete the following information):

• Core: paper
• Version: git-Paper-386 1.19.3

Additional context
Add any other context about the problem here.

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to /Plugins
2. Click on /Plugins/DivineDrop
3. Scroll down to /Plugins/DivineDrop
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
[15:53:46] [Server thread/INFO]: [DivineDrop] Enabling DivineDrop v2.12
[15:53:46] [Server thread/INFO]: [DivineDrop] Current version: v1_20_R2. This version is not supported!
[15:53:46] [Server thread/INFO]: [DivineDrop] Disabling DivineDrop v2.12

Plugin (please complete the following information):

• Version Latest
• Configuration [maybe link or attachment]

Server (please complete the following information):

• Core: Purpur And pufferfish
• Version: 1.20.2

Additional context
Add any other context about the problem here.

Bug description
The plugin have a null object somewhere so when you throw an object nothings appends.
I've look at the plugin source code and I've find nothing so if you have any idea.

here is the log:
java.lang.NullPointerException: Cannot invoke "String.replace(java.lang.CharSequence, java.lang.CharSequence)" because the return value of "com.demkom58.divinedrop.config.ConfigData.getFormat()" is null
at com.demkom58.divinedrop.drop.ItemHandler.getFormattedName(ItemHandler.java:92)
at com.demkom58.divinedrop.drop.ItemRegistry.lambda$handleNewTimedItem$0(ItemRegistry.java:145)
at org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftTask.run(CraftTask.java:81)
at org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftScheduler.mainThreadHeartbeat(CraftSchedulerMixin.java:400)
at net.minecraft.server.MinecraftServer.handler$bbd000$arclight$runScheduler(MinecraftServerMixin.java:2160)
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServerMixin.java)
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServerMixin.java:291)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServerMixin.java:787)
at net.minecraft.server.MinecraftServer.func_240802_v_(MinecraftServerMixin.java:1917)
at net.minecraft.server.MinecraftServer.func_240783_a_(MinecraftServerMixin.java:232)
at java.base/java.lang.Thread.run(Thread.java:840)

Plugin:

• Version 2.14 (same on 2.7.1)

Server (please complete the following information):

• Arclight Serveur, so spigot but modded
• Version: 1.16.5

Describe the bug
I use translation software, so this looks strange, sorry!
Due to possible time difference issues, we may not be able to communicate smoothly. Sorry!

I tried using zh_ CN is used as a language, but it has an error.

To Reproduce
Steps to reproduce the behavior:

1. Open config.yml
2. Change lang to zh_ CN
3. Input /dd reload
4. See error

Expected behavior
Correct language reloading.

Screenshots

Plugin (please complete the following information):

• Version 2.13
• Configuration:

#   ________      ___    ___      ________  _______   _____ ______   ___  __    ________  _____ ______   ________  ________
#  |\   __  \    |\  \  /  /|    |\   ___ \|\  ___ \ |\   _ \  _   \|\  \|\  \ |\   __  \|\   _ \  _   \|\   ____\|\   __  \
#  \ \  \|\ /_   \ \  \/  / /    \ \  \_|\ \ \   __/|\ \  \\\__\ \  \ \  \/  /|\ \  \|\  \ \  \\\__\ \  \ \  \___|\ \  \|\  \
#   \ \   __  \   \ \    / /      \ \  \ \\ \ \  \_|/_\ \  \\|__| \  \ \   ___  \ \  \\\  \ \  \\|__| \  \ \_____  \ \   __  \
#    \ \  \|\  \   \/  /  /        \ \  \_\\ \ \  \_|\ \ \  \    \ \  \ \  \\ \  \ \  \\\  \ \  \    \ \  \|____|\  \ \  \|\  \
#     \ \_______\__/  / /           \ \_______\ \_______\ \__\    \ \__\ \__\\ \__\ \_______\ \__\    \ \__\____\_\  \ \_______\
#      \|_______|\___/ /             \|_______|\|_______|\|__|     \|__|\|__| \|__|\|_______|\|__|     \|__|\_________\|_______|
#               \|___|/                                                                                    \|_________|
# Don't change this
config-version: 3
# Enable update notifications in chat for admins and console.
check-updates: true
# Uses when cleaner disabled or if item hasn't timer.
# Placeholders: %size%, %name%
# Note: [%countdown% placeholder will not be work.]
format: "&f%name% &7(x%size%)"
# Pick up items only with the Shift key.
pickup-items-on-sneak: false
# Ignore no pickup items, for compatibility with another plugins
ignore-no-pickup-items: true

# Name of resources. Example: ru_RU, en_CA, uk_UA, de_DE, mt_MT etc.
# More: https://www.spigotmc.org/resources/divinedrop.51715/
lang: "zh_CN"

messages:
 prefix: "&5&lDivineDrop &7> &f"
 display-name: "Display Name&7: &f%name%"
 no-permission: "&cYou do not have permission to run this command."
 unknown-cmd: "&cYou entered an unknown command."
 reloaded: "&aThe configuration is reloaded."

drop-cleaner:
 enabled: false
 # Placeholders: %countdown%, %size%, %name%
 format: "&c[&4%countdown%&c] &f%name% &7(x%size%)"
 # Global timer
 timer: 10
 # The timer will be added to the items that are loaded along with the chunk.
 timer-for-loaded-items: true
 # Do not remove items dropped from the players.
 save-player-dropped-items: false
 # Enable handle of custom countdowns
 enable-custom-countdowns: false
 custom-countdowns:
   # Material list: https://hub.spigotmc.org/javadocs/spigot/org/bukkit/Material.html
   # Its name timer for all diamond swords. Such name timer will only work on objects that are not in this configuration.
   # That is, if there is already name record in the configuration with name filter by name or emptiness, then this record will not spread to such sword.
   DIAMOND_SWORD:
     name-filter: "*"
     timer: 20
     format: "&c%name% &7(x%size%)"
   # Its timer for an item that is not renamed.
   STICK:
     name-filter: ""
     timer: 20
   # Your timer value on items with your custom name.
   DIAMOND:
     name-filter: "SILVER"
     timer: 50
   # Such name thing will be without name timer and the plugin will not delete it.
   DIAMOND:
     name-filter: "KEEP_SILVER"
     timer: -1
   # It works on all raw fish.
   RAW_FISH:
     timer: -1

Server (please complete the following information):

• Core: Spigot
• Version: CraftBukkit version 3926-Spigot-dba3cdc-ffb1319 (MC: 1.20.2) (Implementing API version 1.20.2-R0.1-SNAPSHOT)
• Plugins (34): CoreProtect, JoinCommands, CrazyAuctionsPlus, PlaceholderAPI, CMILib, PlugMan, SimpleHomes, DeluxeTags, LiteSignIn, TrChat, MiaoBoard, PVPMode, mcMMO, ViaVersion, JulyLibrary, NBTAPI, floodgate, ViaBackwards, LuckPerms, JulySafe, SkinsRestorer, Vault, GemsEconomy, ResourceWorld, PlayerPoints, CMI, Multiverse-Core, TrMenu, Citizens, Shopkeepers, Residence, BetterRTP, QuickShop, DivineDrop

Additional context
None.

este plugin es un troyano

Support update required for version 1.18.2

Is your feature request related to a problem? Please describe.
I'll be short, I have a plugin called CrackShot & MoneyFromMobs, both plugins rename the dropped items to their unique ID to recognize them, and that unique displays as the name in DivineDrop. I would appreciate a option to define items that DivineDrop will completely ignore, in other words, not even show the fancy name (because it also conflicts with the one provided by MoneyFromMobs / CrackShot).

Describe the solution you'd like
I just want a option in config to add ignored items by DivineDrop, which will completely ignore them.

Describe alternatives you've considered
To fix the CrackShot issue I just defined the items with custom format countdown, however this cannot be done with MoneyFromMobs as it updates and conflicts with the name displayed by DivineDrop.

NETHER_BRICK:
  name-filter: "*"
  timer: -1
  format: "&eFrag Grenade"
PRISMARINE_CRYSTALS:
  name-filter: "*"
  timer: -1
  format: "&eFlashbang"

Additional context
Not applicable, suggestion/idea is pretty simple and self explanatory.

Hi.

With 1.16.4 DivineDrop stopped working. Could you please add support for 1.16.4?

Is this plugin client side? I dont wanna the plugin to modify heads on ground or trigger exploits.

Can not download new update.

Steps to reproduce the behavior:

1. go to dowload
2. try to download
3. download fails (virus detected)

Expected behavior
Just download the jar file

Can you add 1.20.4 support.

Update to 1.19 pls

Often, players from different countries can play on the same server and their preferred languages may be different from the default ones set by the administrator.

To solve this descripted problem, we can add the option to enable packet entity item name replacement depending on the player’s country.

Drop removal can be made much more beautiful.
We can play sounds and particle effects when removing a drop.

PLS add all Blocks up to 1.19

i search in the de_DE.lang
and found only
"subtitles.block.beehive.drip": "Honig tropft",
so thinks like Dripstone are not in it.

so many item names are just minecraft:NAME_OF_ITEM

Describe the solution you'd like
A world specific timer, for example in the nether if a player dies they always complain that their stuff depsawns etc, so it would be really usuful to set and additional time for nether/end to like 5-10 minutes

This would also be suful for other thins i'd assume, ive also turned on the save player items option but they still seem to despawn anyways

(also discord would be more usful for support than github)

PLAYER can mine ore and get diamond、emerald etc.. again and again in other's claim without breaking permission

update for 1.21 support.

At that moment version dependent code are stored in version packages of single module.

It's bad because:

1. Other versions NMS code can be imported to different version code that can produce errors.
2. Currently maven minecraft jars can't be loaded from m2 repo.
3. Sometimes it can produce errors in IDE. (because there are repeating files in different jars).

In best case it should be moved to gradle modules and than included to master module.

save-player-dropped-items: true

When this item is turned on, the drops caused by the death of the player cannot be saved, and they will still be cleaned up.