devakone / ng-open-cv Goto Github PK

While working with this library I've found that the options object does not get applied (the DEFAULT_OPTIONS are always applied).

After some digging, I think the problem is in this line (the provided options object is missing the spread operator):

I think the correct solution should be:

const opts = { ...this.DEFAULT_OPTIONS, ...options }; 

Just tried testing this and the service creates a wrong path for me in this function:

private locateFile(path, scriptDirectory): string {
    if (path === 'opencv_js.wasm') {
      return scriptDirectory + '/wasm/' + path;
    } else {
      return scriptDirectory + path;
    }
}

The adding of the '/wasm/' result in an incorrect link as the path already seems to be 'http://localhost:4200/assets/opencv/wasm/3.4/'.
This is happening in Angular10 in development mode.

After I take a look at this package, i just wonder how can use this OpenCV library for Angular to the more updated version of Angular Platform such as Angular 10.

Furthermore, I have learnt that OpenCV has been updated to version 4.5.3 which I have found when I compile the raw OpenCV library into OpenCV.js by using Emscripten 2.0.10 which have resulted in the following files:

loader.js
opencv.js
opencv_js.js

I just wonder if I can use the updated version of OpenCV.js to update ng-open-cv library.

Great work with this library! Adapted it to fit my own needs in a project I am doing myself.

Just a suggestion I also added to my project, it could be nice to include OpenCV typings. Many have been defined by the great work of the guys at https://github.com/justadudewhohacks/opencv4nodejs!

Check out https://github.com/justadudewhohacks/opencv4nodejs/tree/master/lib/typings

Keep it up!

On trying to load the library in Safari on iOS 11, you get 2 errors:

Assertion failed: no binaryen method succeeded.

and

abort("Assertion failed: no binaryen method succeeded."). Build with -s ASSERTIONS=1 for more info.

Which results in OpenCV failing to load and causing a

ReferenceError: Can't find variable: cv

error.

Hi Devakone,

While calling the cv.imread() function from angular I am getting the output as attached below, which I am not able to interpret. I am expecting a output like python opencv imread, i.e. a MxNx3 matrix.
Could you please help me to map the angular output with python output.

Attaching angular outputs below.

Add CI Tests and basic CI integration with TravisCI