Comments (3)
Can you demonstrate this bug on a POD or STL type such that it can be duplicated?
DoNotOptimizeAway takes a reference. In this case, it should take a reference to the result of the "u+v" operation and should not at all change the results or the way "u+v" is computed.
from celero.
I think STL is too complicated for compiler, but for POD, compiler can do great job. I created a small example:
#include <celero/Celero.h>
#include <eigen3/Eigen/Eigen>
CELERO_MAIN;
Eigen::Vector3f u, v;
struct Vec {
float x, y, z;
};
Vec a, b;
Vec add(const Vec& a, const Vec& b) {
Vec c;
c.x = a.x + b.x;
c.y = a.y + b.y;
c.z = a.z + b.z;
return c;
}
BASELINE(DemoSimple, Baseline, 0, 7100000)
{
asm("# test eigen begin");
celero::DoNotOptimizeAway(Eigen::Vector3f(u + v));
asm("# test eigen end");
asm("# test POD begin");
celero::DoNotOptimizeAway(add(a, b));
asm("# test POD end");
}
The assembler I got from gcc 4.7 is
# 22 "/home/xu/projects/Celero/examples/bug_report.cpp" 1
# test eigen begin
# 0 "" 2
#NO_APP
movss u(%rip), %xmm0
addss v(%rip), %xmm0
movss %xmm0, (%rsp)
call getpid
cmpl $1, %eax
je .L68
.L65:
#APP
# 24 "/home/xu/projects/Celero/examples/bug_report.cpp" 1
# test eigen end
# 0 "" 2
# 26 "/home/xu/projects/Celero/examples/bug_report.cpp" 1
# test POD begin
# 0 "" 2
#NO_APP
movss a(%rip), %xmm0
addss b(%rip), %xmm0
movss %xmm0, 16(%rsp)
call getpid
cmpl $1, %eax
je .L69
.L66:
#APP
# 28 "/home/xu/projects/Celero/examples/bug_report.cpp" 1
# test POD end
With bugfix, the result is follow, so you can see the difference.
# 22 "/home/xu/projects/Celero/examples/bug_report.cpp" 1
# test eigen begin
# 0 "" 2
#NO_APP
movss u(%rip), %xmm0
addss v(%rip), %xmm0
movss %xmm0, (%rsp)
movss u+4(%rip), %xmm0
addss v+4(%rip), %xmm0
movss %xmm0, 4(%rsp)
movss u+8(%rip), %xmm0
addss v+8(%rip), %xmm0
movss %xmm0, 8(%rsp)
call getpid
cmpl $1, %eax
je .L65
.L68:
#APP
# 24 "/home/xu/projects/Celero/examples/bug_report.cpp" 1
# test eigen end
# 0 "" 2
# 26 "/home/xu/projects/Celero/examples/bug_report.cpp" 1
# test POD begin
# 0 "" 2
#NO_APP
movss a+4(%rip), %xmm1
movss a+8(%rip), %xmm0
addss b+4(%rip), %xmm1
movss a(%rip), %xmm2
addss b+8(%rip), %xmm0
addss b(%rip), %xmm2
movss %xmm1, 20(%rsp)
movss %xmm0, 24(%rsp)
movss %xmm2, 16(%rsp)
call getpid
cmpl $1, %eax
je .L71
.L67:
#APP
# 28 "/home/xu/projects/Celero/examples/bug_report.cpp" 1
# test POD end
from celero.
Acknowledged. I see there is a problem here. I am checking in a fix. The fix for Visual Studio is not as nice as for gcc & clang, but I believe it addresses this issue. Thanks for the bug report!
from celero.
Related Issues (20)
- Multiple warnings during compilation via Microsoft Visual Studio HOT 1
- Compiler errors with aggressive warnings enabled
- error: loop variable 'udm' of type 'const std::__1::shared_ptr<celero::UserDefinedMeasurement>' creates a copy from type 'const std::__1::shared_ptr<celero::UserDefinedMeasurement>' HOT 1
- Documentation link not present in README HOT 1
- Samples and iterations are only computed for first size of problem space (division by zero)
- UDM Fields are not printed properly
- Add User Defined Measurements to output files HOT 1
- Test executable fails: No Baseline case defined for "". Exiting.*** Error code 1 HOT 1
- ARCHIVE_OUTPUT_NAME always has ".dll" even for static builds
- Support vcpkg --triplet x64-windows-static-md
- celero 2.8.0 OSX test build failure HOT 3
- Tests terminate with Signal 11 HOT 4
- Truncation of group and experiment names in standard output HOT 1
- Problems with building / packaging celero HOT 5
- Passing invalid group name in the command line segfaults HOT 1
- [2.8.4 regression] c++: error: no such file or directory: '/wd4251' HOT 1
- Memory Measurement on macOS HOT 3
- Add User-Defined String field to Result Table CSV HOT 3
- Celero/experiments/ExperimentCompressBools has a bad cast HOT 2
- CMAKE_<BUILD_TYPE>_POSTFIX spills into consuming project HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from celero.