Comments (7)
dreyescat
commented on September 28, 2024
2
Merged and released 👍. Thanks for the fix @darkowic.
from react-rating.
ishake
commented on September 28, 2024
1
I'm having the same issue. Hoping the fix will be merged soon. :)
from react-rating.
mkarajohn
commented on September 28, 2024
Noted, will get onto it as soon as I have some time available today. Or
feel free to give it a try yourself in the meantime :)
…On Thu, Jan 4, 2018 at 2:50 PM, Dariusz Rzepka ***@***.***> wrote:
The example for an svg element is not working. http://dreyescat.github.io/
react-rating/
I can not use the new release because of this bug.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#69>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADnRqs5M-XWtAq-SXMLwEGKPfi3PMQuzks5tHMkggaJpZM4RS-XL>
.
from react-rating.
darkowic
commented on September 28, 2024
Problem is that svg hovering area is very small. When you hovering at the bottom of rating icons it works correctly. I'm trying to debug it locally
from react-rating.
darkowic
commented on September 28, 2024
This is problem with calculating value under cursor somewhere in function calculateDisplayValue. calculateHoverPercentage returns NaN when hovering on svg. I think I can handle it soon.
from react-rating.
darkowic
commented on September 28, 2024
I solved the problem. I will post pull request soon
from react-rating.
darkowic
commented on September 28, 2024
@mkarajohn @dreyescat Pull request waits for merge and publish :)
from react-rating.
Related Issues (20)
- Initial Rating returns null only renders once
- on version 2.0.1 ReactRating-component onChange-event seems to return always value of initialRating HOT 15
- Error during installation on jenkins HOT 2
- emptySymbol is not hidden when fullSymbol is displayed HOT 9
- Cannot read property 'type' of undefined
- Method comments are switched HOT 1
- Misalignment HOT 4
- Sorry HOT 1
- All touches, even scroll/swipe gestures trigger "onClick" HOT 8
- Warning: Using UNSAFE_componentWillReceiveProps in strict mode is HOT 11
- Warning: Using UNSAFE_componentWillReceiveProps in strict mode is not recommended and may indicate bugs in your code. See https://reactjs.org/link/unsafe-component-lifecycles for details. HOT 5
- Feature request: Lighter DOM Size HOT 1
- Doesn't work with react 17 HOT 1
- Selection requires double click if onClick method provided HOT 3
- How to add the validation for the rating component HOT 1
- Add option to remove default style
- mixed symbol but react component HOT 1
- Package should be marked as deprecated and a replacement fork nominated HOT 2
- React 18: TS2786: 'Rating' cannot be used as a JSX component. HOT 9
- `@types` dependencies should be in `devDependencies`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-rating.