Comments (5)
"If it is a URL the content should be a-synced in and then an Iframe should be created " -- if we're AJAXing the content in from the URL, why do we need an iFrame?
from lu.
The use cases for Loader were:
Loading content or in a tip (Mini profile)
Loading content in an accordion panel
Loading content in a tab.
Loading content in a dialog.
The above should say "If it is a URL from the same domain the content should be a-synced in otherwise, an Iframe should be created..."
I was probably hopped up on pain killer at the time of writing the above ...
In truth, we should probably give the option to force the content into an iframe even if the url originated from the same domain.
Container will be useful for other controls to extend or use. IMO because the events on other controls vary container should not inherently respond to any events. Rather, Controls like Dialog should respond to a close event ant call a close method on container. Likewise Accordion could respond to an expand event, get the content height of the containers content and then expand the container.
from lu.
It sounds to me like Loader should inherit from Container -- is that what you're thinking? And Tip could inherit from Loader as well.
I don't recall why we originally had Container create an internal instance of Loader, instead of going the inheritance route...?
I agree on the iframe option, too.
from lu.
Container & Loader are mostly done. Examples in Primer (also for Tip). Still need to create unit tests w/Kiro's help....
from lu.
Nice!
from lu.
Related Issues (20)
- Write an architectural primer
- Write mappers primer
- Container example doesn't work HOT 1
- Load Button does not work HOT 1
- Keybindings for multiple components? HOT 2
- Write event tests for Switch
- Write Unit tests for Button
- Write Unit Tests for Container HOT 1
- Lists selected event fires twice
- Prevent Default & Buttons HOT 6
- States that overlap with ARIA states should apply the associated aria attribute
- Transient Unit Tests Failures for Switch and Abstract HOT 1
- Drawer HOT 3
- Sequence
- hoverIntent
- dependancies-resolved out of order
- Respect the hash stack HOT 1
- Mapper.js vanished? HOT 2
- Object Literal as Event-Trigger Payload HOT 1
- Add a destroy method to garbage collect events in Lu core
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lu.