Giter VIP home page Giter VIP logo

Comments (5)

Jimgskoop avatar Jimgskoop commented on September 1, 2024

"If it is a URL the content should be a-synced in and then an Iframe should be created " -- if we're AJAXing the content in from the URL, why do we need an iFrame?

from lu.

Iheartweb avatar Iheartweb commented on September 1, 2024

The use cases for Loader were:

Loading content or in a tip (Mini profile)
Loading content in an accordion panel
Loading content in a tab.
Loading content in a dialog.

The above should say "If it is a URL from the same domain the content should be a-synced in otherwise, an Iframe should be created..."

I was probably hopped up on pain killer at the time of writing the above ...

In truth, we should probably give the option to force the content into an iframe even if the url originated from the same domain.

Container will be useful for other controls to extend or use. IMO because the events on other controls vary container should not inherently respond to any events. Rather, Controls like Dialog should respond to a close event ant call a close method on container. Likewise Accordion could respond to an expand event, get the content height of the containers content and then expand the container.

from lu.

Jimgskoop avatar Jimgskoop commented on September 1, 2024

It sounds to me like Loader should inherit from Container -- is that what you're thinking? And Tip could inherit from Loader as well.

I don't recall why we originally had Container create an internal instance of Loader, instead of going the inheritance route...?

I agree on the iframe option, too.

from lu.

Jimgskoop avatar Jimgskoop commented on September 1, 2024

Container & Loader are mostly done. Examples in Primer (also for Tip). Still need to create unit tests w/Kiro's help....

from lu.

Iheartweb avatar Iheartweb commented on September 1, 2024

Nice!

from lu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.