JsLint (all the good parts) lu.js about lu HOT 7 CLOSED

Here's the remaining complaints from JSLint on lu.js:

lint:lu.js:28:31:Expected an identifier and instead saw 'undefined' (a reserved word).
jslint:lu.js:191:32:The Function constructor is eval.
jslint:lu.js:415:82:'JSONify' was used before it was defined.
jslint:lu.js:415:82:Missing 'new'.

Thoughts?

-Jim G

from lu.

I am mostly concerned with

jslint:lu.js:415:82:'JSONify' was used before it was defined.

I can't find where JSONify is defined anywhere within Lu. Did we forget to include a library or something...?

-Jim G

from lu.

Hmmm....

this line: return $element.attr( ATTR, keys.join( ' ' ) ).attr( ATTR + '-config', JSONify( settings ) ); should be
return $element.attr( ATTR, keys.join( ' ' ) ).attr( ATTR + '-config', JSON.stringify( settings ) );

from lu.

Yeah, agree that's the only one that's problematic.

from lu.

I fixed the "JSONify" problem

from lu.

That makes more sense!

;)

-Jim G

On Apr 7, 2012, at 3:18 AM, Robert Martone <[email protected]

wrote:

Hmmm....

this line: return $element.attr( ATTR, keys.join( ' ' ) ).attr( ATTR

• '-config', JSONify( settings ) ); should be
  return $element.attr( ATTR, keys.join( ' ' ) ).attr( ATTR + '-
  config', JSON.stringify( settings ) );

---

Reply to this email directly or view it on GitHub:
https://github.com/Iheartweb/Lu/issues/71#issuecomment-5007239

from lu.

Looking good now.

from lu.