[Debug] Support "attach" to the AUD from the Debug Adapter Launcher configuration about lsp4e HOT 5 OPEN

Hi @apupier - This is handled by adding the "request": "attach" to your Launch Parameters JSON:

The code that does the launch or attach request is

If you want to set your launch/attach based on some other UI/setting - you can intercept the creation of the debug target by overriding DSPLaunchDelegate.createDebugTarget:

I haven't tried this recently and I am not on a dev machine right now that allows me to quickly verify, but please let me know if this is what you were actually asking about.

from lsp4e.

PS. PR #56 referred to this issue, it may be updating the new docs based on the above is useful?

from lsp4e.

Ok using the "request": "attach" in the launch parameter json field is working.
is ti coming from the protocol or from the LSP4E implementation?
if from protocol, it sound sweird that there is 2 different methods if we expect this attribute.
If from LSP4E implementation, it means that we might have a collision of attributes if there is a request parameters expected.

I will update the documentation anyway to reflect current state and help other users. I spent quite some time to be able to use the launch config due to this issue so hope it will save time for others.

from lsp4e.

Ok using the "request": "attach" in the launch parameter json field is working.

Great :-)

is ti coming from the protocol or from the LSP4E implementation?

LSP4E implementation.

if from protocol, it sound sweird that there is 2 different methods if we expect this attribute. If from LSP4E implementation, it means that we might have a collision of attributes if there is a request parameters expected.

The request (like name and type) are attributes in the launch settings that are used by the client, not by the server. In VSCode's launch.json file format these attributes are all in the same bit of json. A debug server can't have request/name/type as attributes because of this. I don't know if vscode/dap document this limitation anywhere though - and who knows what happens if vscode decides they need a new attribute (actually I know it is likely https://github.com/weinand who makes that decision!).

Does that resolve your question(s)?

I will update the documentation anyway to reflect current state and help other users. I spent quite some time to be able to use the launch config due to this issue so hope it will save time for others.

I really appreciate you asking the question - and even more taking the time to document it for the next person!

from lsp4e.

The request (like name and type) are attributes in the launch settings that are used by the client, not by the server. In VSCode's launch.json file format these attributes are all in the same bit of json. A debug server can't have request/name/type as attributes because of this. I don't know if vscode/dap document this limitation anywhere though - and who knows what happens if vscode decides they need a new attribute (actually I know it is likely https://github.com/weinand who makes that decision!).

Does that resolve your question(s)?

yes, it does.
I think it will be useful to provide this kind of information. Maybe not only in the documentation but also directly in the UI. (maybe as a tooltip on an information icon?)

I really appreciate you asking the question - and even more taking the time to document it for the next person!

The project helps me a lot to provide a debugger for my use case. That's normal to contribute back.

from lsp4e.