Giter VIP home page Giter VIP logo

Comments (14)

tsiren avatar tsiren commented on August 31, 2024

Checked that sv_snapshot:c func SV_AddEntitiesVisibleFromPoint

// calculate the visible areas
frame->areabytes = CM_WriteAreaBits( frame->areabits, clientarea );

indeed calculates 79 bytes

from ete.

ensiform avatar ensiform commented on August 31, 2024

CM_WriteAreaBits unchanged from GPL release ET repo though.

from ete.

tsiren avatar tsiren commented on August 31, 2024

Related variables within that function

origin: 64.000000 272.000000 137.000000
leafnum 24119, clientarea 0, clientcluster 23483
floodnum: 1, numareas 630

from ete.

tsiren avatar tsiren commented on August 31, 2024

bytes = ( cm.numAreas + 7 ) >> 3;

This shouldn't return more than 32 so something wrong with the numAreas value 630

from ete.

tsiren avatar tsiren commented on August 31, 2024

Based on that max value for numAreas is 256

from ete.

tsiren avatar tsiren commented on August 31, 2024

As mentioned in Discord the official binary differs from the original released sources.

if ( len > sizeof( newSnap.areamask ) ) {
Com_Error( ERR_DROP,"CL_ParseSnapshot: Invalid size %d for areamask.", len );
return;
}

This error string is missing from the released binary. You can verify this by running strings in linux.

from ete.

ensiform avatar ensiform commented on August 31, 2024

And removing it causes other problems still?

from ete.

tsiren avatar tsiren commented on August 31, 2024

It loaded the level but crashes shortly after, I could try some more experimenting

from ete.

ensiform avatar ensiform commented on August 31, 2024

I do not actually have a copy of ET.exe retail release at the moment for some reason so I can't actually confirm if the message is missing from there too. My guess is they added it during the time they added the directory traversal fixes to the code post-release similar to what happened with dirtrav fixes for Q3A, post-Q3 GPL.

from ete.

tsiren avatar tsiren commented on August 31, 2024

I verified that it's also missing from the Windows version.

from ete.

tsiren avatar tsiren commented on August 31, 2024

The level loads fine in ETe if I comment out the size check. You can verify this in your Win build also. It crashes when joining a team which happens in vanilla as well.. I assume you need the ETRun mod when joining a team?

from ete.

ensiform avatar ensiform commented on August 31, 2024

I think suburb told me it should still work without the mod. Need confirmation

from ete.

tsiren avatar tsiren commented on August 31, 2024

I scrolled the discord messages and you should be able to play it without the mod. This means there is more to it than just the error message. It crashes in a way that it totally freezes so I don't get any stack trace. I could try to see where the instruction pointer is but ... maybe trying ETe(remove the error msg) + ETRun gives us better info or the same end result.

from ete.

ensiform avatar ensiform commented on August 31, 2024

Closing but I don't really like that we don't have this check still.

from ete.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.