src paths for files are '/' and for a static site should be './' in build about create-react-app HOT 9 CLOSED

I think the problem with ./ is it doesn’t work for single page apps with routing.
For example when you load localhost:3000/products, you don’t want to load products/main.js.

Since most React apps are single page apps (and most SPAs use HTML5 history over hashes these days), I think we we’ll have to stick with requiring a server for the bundle. But maybe I’m wrong.

from create-react-app.

@vjeux Thanks for the response!

Yea so currently if I am in a gh-pages branch and run:

fs.readdirSync("./").forEach(toBeErased => {
  if (toBeErased === "react-gh.js" || toBeErased === "build" || toBeErased === ".git" || toBeErased === "node_modules" | toBeErased === "src") {

  } else {
    fs.unlinkSync(toBeErased)
  }
})

fs.readdirSync('build').forEach(file => {
  fileContents = fs.readFileSync(`build/${file}`)
  fs.writeFileSync(file, fileContents)
})

Everything looks fine, but the html is clueless haha.

I got it to work perfectly after manually changing the paths :)

from create-react-app.

@gaearon Never thought about the routing part. Good catch

from create-react-app.

Sorry, deleted my response. #21 is also talking about the same issue

from create-react-app.

@vjeux Is that just for the package.json or does that include the src for the script and link tags?

from create-react-app.

Ok it seems this is being covered in multiple Issues. I couldn't tell from the titles!

Feel free to keep open or close

from create-react-app.

Let’s continue in #21.

from create-react-app.

GH Pages should work with 0.2.0 alpha, here's how to test it: #190

from create-react-app.

Fantastic! Thanks for the update

from create-react-app.