farhan7500 / hpe3par_ansible_module Goto Github PK

In remote copy modules current implementation requires user to input the target_mode values as "string"
while the mode value requires user to enter an "integer"
For user convenience these two values should either take a string value or should only accepted integer for consistency.

Provide an invalid value in source_port": "0:3:e field, the message is should be specific to the field as is the case in 3par

Node port:
fatal: [localhost]: FAILED! => {
"changed": false,
"invocation": {
"module_args": {
"different_secondary_wwn": false,
"discard_new_data": false,
"domain": null,
"full_sync": false,
"keep_snap": false,
"local_groups_direction": false,
"local_remote_volume_pair_list": null,
"local_snap_cpg": null,
"local_user_cpg": null,
"no_resync_snapshot": false,
"no_snapshot": false,
"recovery_action": null,
"remote_copy_group_name": null,
"remove_secondary_volume": false,
"skip_initial_sync": false,
"skip_promote": false,
"skip_start": false,
"skip_sync": false,
"snapshot_name": null,
"source_port": "0:3:e",
"starting_snapshots": null,
"state": "admitlink",
"stop_groups": false,
"storage_system_ip": "192.168.67.5",
"storage_system_password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
"storage_system_username": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
"target_mode": null,
"target_name": "CSSOS-SSA06",
"target_port_wwn_or_ip": "192.168.1.2",
"targets": null,
"unset_snap_cpg": false,
"unset_user_cpg": false,
"volume_auto_creation": false,
"volume_name": null
}
},
"msg": "Admit remote copy link failed | Illegal integer argument e\r"

3par output:

CSSOS-SSA05 cli% admitrcopylink CSSOS-SSA04 0:3:e:192.168.1.2
Illegal integer argument e
Error: Invalid Port number: e

If a remote copy link already exists, and the user provides an incomplete IP address, the playbook does not fail with invalid IP error. The same succeeds with message remote copy already exists.

ok: [localhost] => {
"changed": false,
"invocation": {
"module_args": {
"different_secondary_wwn": false,
"discard_new_data": false,
"domain": null,
"full_sync": false,
"keep_snap": false,
"local_groups_direction": false,
"local_remote_volume_pair_list": null,
"local_snap_cpg": null,
"local_user_cpg": null,
"no_resync_snapshot": false,
"no_snapshot": false,
"recovery_action": null,
"remote_copy_group_name": null,
"remove_secondary_volume": false,
"skip_initial_sync": false,
"skip_promote": false,
"skip_start": false,
"skip_sync": false,
"snapshot_name": null,
"source_port": "1:3:1",
"starting_snapshots": null,
"state": "admitlink",
"stop_groups": false,
"storage_system_ip": "192.168.67.5",
"storage_system_password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
"storage_system_username": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
"target_mode": null,
"target_name": "CSSOS-SSA06",
"target_port_wwn_or_ip": "192.168.2.",
"targets": null,
"unset_snap_cpg": false,
"unset_user_cpg": false,
"volume_auto_creation": false,
"volume_name": null
}
},
"msg": "Admit remote copy link 1:3:1:192.168.2. already exists."

Admitrcopylink module fails when some source_port values are not enclosed within quotes

fatal: [localhost]: FAILED! => {
"changed": false,
"invocation": {
"module_args": {
"different_secondary_wwn": false,
"discard_new_data": false,
"domain": null,
"full_sync": false,
"keep_snap": false,
"local_groups_direction": false,
"local_remote_volume_pair_list": null,
"local_snap_cpg": null,
"local_user_cpg": null,
"no_resync_snapshot": false,
"no_snapshot": false,
"recovery_action": null,
"remote_copy_group_name": null,
"remove_secondary_volume": false,
"skip_initial_sync": false,
"skip_promote": false,
"skip_start": false,
"skip_sync": false,
"snapshot_name": null,
"source_port": "3781",
"starting_snapshots": null,
"state": "admitlink",
"stop_groups": false,
"storage_system_ip": "192.168.67.5",
"storage_system_password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
"storage_system_username": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
"target_mode": null,
"target_name": "CSSOS-SSA06",
"target_port_wwn_or_ip": "192.168.2.2",
"targets": null,
"unset_snap_cpg": false,
"unset_user_cpg": false,
"volume_auto_creation": false,
"volume_name": null
}
},
"msg": "Admit remote copy link failed | Illegal integer argument 3781. Expected range [0-7].\r"
}

Note: Issue reported by Arshad

Create RCG group with local and remote user and snap CPG set. The playbook fails with error message
"msg": "implementation error: unknown type string requested for local_user_cpg