Comments (9)
daffl
commented on September 28, 2024
Isn't this a duplicate of feathersjs-ecosystem/authentication#576?
from authentication-oauth2.
nabeards
commented on September 28, 2024
I suppose that it is! Since it appears to be an issue with this repo and not that one, I didn't think to look there for the issue. Sorry about that.
from authentication-oauth2.
nsainaney
commented on September 28, 2024
You're both right. I've submitted a PR that proposes a solution. Not sure if extending the strategy options is part of your design principles but it works well.
from authentication-oauth2.
nabeards
commented on September 28, 2024
Is there a reason not to send the full oauth2settings object? Just curious.
from authentication-oauth2.
nsainaney
commented on September 28, 2024
@nabeards I suppose you're right. It's not like there will be any conflict in the settings. I'll update my PR
from authentication-oauth2.
nsainaney
commented on September 28, 2024
Do you think the call to:
app.get(oauth2Settings.path, auth.express.authenticate(name));
should pass in oauth2Settings or oauth2Settings[name]? In other words, for google, oauth2Settings.google subdocument will be passed in.
from authentication-oauth2.
nabeards
commented on September 28, 2024
I think the 'google' subdoc from the current config file is what oauth2Settings is populated with now.
"google": {
"clientID": "GOOGLE_CLIENT_ID",
"clientSecret": "GOOGLE_CLIENT_SECRET",
"callbackURL": "GOOGLE_CALLBACK_URL",
"successRedirect": "GOOGLE_SUCCESS_REDIRECT",
"accessType": "offline",
"includeGrantedScopes": true,
"scope": [
"openid",
"profile",
"email",
"https://www.googleapis.com/auth/drive.readonly",
"https://www.googleapis.com/auth/drive.metadata"
]
},
Are you suggesting a structure like this?
"google": {
"clientID": "GOOGLE_CLIENT_ID",
"clientSecret": "GOOGLE_CLIENT_SECRET",
"callbackURL": "GOOGLE_CALLBACK_URL",
"successRedirect": "GOOGLE_SUCCESS_REDIRECT",
"google": {
"accessType": "offline",
"includeGrantedScopes": true,
"scope": [
"openid",
"profile",
"email",
"https://www.googleapis.com/auth/drive.readonly",
"https://www.googleapis.com/auth/drive.metadata"
]
}
},
Seems redundant to have google.google. Just my 2¢.
from authentication-oauth2.
nsainaney
commented on September 28, 2024
No I was proposing your first example. I'll send a PR today.
"google": {
"clientID": "GOOGLE_CLIENT_ID",
"clientSecret": "GOOGLE_CLIENT_SECRET",
"callbackURL": "GOOGLE_CALLBACK_URL",
"successRedirect": "GOOGLE_SUCCESS_REDIRECT",
"accessType": "offline",
"includeGrantedScopes": true,
"scope": [
"openid",
"profile",
"email",
"https://www.googleapis.com/auth/drive.readonly",
"https://www.googleapis.com/auth/drive.metadata"
]
}
from authentication-oauth2.
daffl
commented on September 28, 2024
Closed via #42
from authentication-oauth2.
Related Issues (20)
- How to setup a dynamic URL parameters to successRedirect URL HOT 1
- Callback URL problem in production when using oauth HOT 4
- Cannot connect with OAuth2, always getting 404 Not Found Page. HOT 4
- I get Internal server error after I auth with Google authentication HOT 1
- `facebook.profileFields` not works properly HOT 2
- Dependency @feathersjs/express not declared HOT 2
- how to use proxy when call authnetication provider HOT 5
- I got Internal error when I log in with google HOT 1
- JWT Payload is null after app logout HOT 2
- How to pass successUrl from client side? HOT 1
- Deleted
- Confusing in doc of 'OAuth2 Authentication' HOT 2
- Error when save callback payload google login into users service HOT 4
- Restricting certain email domains HOT 1
- Authentication always logging as first user HOT 1
- How to authenticate token from Facebook on Feathers server HOT 3
- JWT sub is always 'anonymous' after using verifier HOT 1
- Cannot use Passport-Google-Token through POST request on /authentication HOT 7
- Entity could be an array? HOT 1
- DefaultVerifier profile id field not configurable HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from authentication-oauth2.