Giter VIP home page Giter VIP logo

Comments (4)

chee avatar chee commented on September 27, 2024

removing the line of code locally seems to make the links work fine, but I do not have context on why it was added initially.
@notlee do you remember why we added this?

from origami-build-service.

notlee avatar notlee commented on September 27, 2024

I don't remember... digs

Looks like it had been set for years then was removed and then I bought it back soon after. Looks like I was under the false impression that it would apply to absolute links like /v2/docs/api, for when Build Service is hosted locally, on a heroku domain, or at https://www.ft.com/__origami/service/build/

We should remove it but confirm absolute links are set using the @root.basePath variable...

href="{{@root.basePath}}{{href}}"

from origami-build-service.

chee avatar chee commented on September 27, 2024

okay, so it's because of that subdirectory we serve the production version on.

so:

  1. update all href="/* to href="{{@root.basePath}}/*
  2. remove the <base>

from origami-build-service.

JakeChampion avatar JakeChampion commented on September 27, 2024

Closing this as looks like #551 fixes the issue

from origami-build-service.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.