fxhash / fxhash-boilerplate Goto Github PK

The read me of this repository currently say:
npx degit fxhash/params-boilerplate your_project_name

Maybe it should say:
npx degit fxhash/fxhash-boilerplate your_project_name

Because it's weird to point to another non updated template, when the official doc point to this specific template no?
Or is there a reason that I don't see for still directing people to use a previous template ?

In fxhash site said "the ZIP file must be <= 30 MB. Please try to optimize your projects as much as possible." but in the README.md file it says the code file must be less than 15MB. So please check and update , it confusing to new developers who tries to understand the system.

add <meta charset="utf-8"> to index.html

Please see the following report:

# npm audit report

async  2.0.0 - 2.6.3
Severity: high
Prototype Pollution in async - https://github.com/advisories/GHSA-fwr7-v2mv-hh25
fix available via `npm audit fix`
node_modules/async

follow-redirects  <1.14.8
Severity: moderate
Exposure of Sensitive Information to an Unauthorized Actor in follow-redirects - https://github.com/advisories/GHSA-pw2r-vq6v-hr8c
fix available via `npm audit fix`
node_modules/follow-redirects

minimist  <1.2.6
Severity: critical
Prototype Pollution in minimist - https://github.com/advisories/GHSA-xvch-5gv4-984h
fix available via `npm audit fix`
node_modules/minimist

node-forge  <=1.2.1
Severity: high
Improper Verification of Cryptographic Signature in `node-forge` - https://github.com/advisories/GHSA-2r2c-g63r-vccr
Improper Verification of Cryptographic Signature in node-forge - https://github.com/advisories/GHSA-x4jg-mjrx-434g
Improper Verification of Cryptographic Signature in node-forge - https://github.com/advisories/GHSA-cfm4-qjh2-4765
fix available via `npm audit fix`
node_modules/node-forge

terser  5.0.0 - 5.14.1
Severity: high
Terser insecure use of regular expressions before v4.8.1 and v5.14.2 leads to ReDoS - https://github.com/advisories/GHSA-4wf5-vphf-c2xc
fix available via `npm audit fix`
node_modules/terser

I'll make a PR that updates package-lock.json after running npm audit fix

Hey all, are there any existing type definitions for the API and if not would there be any interest? Is this considered (relatively) stable or still too early? I'm working on updating my own project template, but could feed those type parts back to here if there's interest. Let me know pls!

This might be an oversight, but there is no license assigned to the boilerplate.

According to choosealicense this might mean that the boilerplate is under exclusive copyright by default.

Could we maybe add a LICENSE?

EDIT: Other fxhash repos also don't specify a license. It would be nice if they did, in order to protect contributors and users.

Thanks!

I don't see that things in src/index.js (referenced via relative path from index.html: "../src/index.js") are being included in the result. If they are not, then I suggest that you change the location of index.js so that it is in or under public. That will make its usage more obvious.

There is small typo in the repo description.

boiletplate -> boilerplate

hi,

This also affects the hackathon 2023 branch:

If you do something like http://localhost:3300/?target=http://localhost:3301?foo=123&bar=789

const sp = new URLSearchParams(window.location.search)
console.log(sp.get("bar"))

Expects

// 789

Recieves

// null

It's very common to use git in the project, in this case doing npx fxhash build includes the .git folder (which can be huge) inside the resulting compressed file.

$ git clone https://github.com/fxhash/fxhash-webpack-boilerplate.git your_folder && cd your_folder
$ git clone https://github.com/fxhash/fxhash-webpack-boilerplate.git your_folder && cd your_folder
^^^

Uncaught SyntaxError: Unexpected identifier

It's saying that git is an unexpected identifier - do you know what I'm doing wrong?

As far as my understanding goes, right now $fx.params() can be used once to define params. When I want to add more params, I have to do this:

$fx.params($fx.getDefinitions().concat([{
  "id": "new_param",
  "name": "New param",
  "type": "boolean",
}]));

And if I want to change an existing param, I have to know its index in the list:

$fx.params($fx.getDefinitions().slice(0, -1).concat([{
  "id": "replacing_param",
  "name": "Replacing last param",
  "type": "boolean",
}]));

or:

$fx.params($fx.getDefinitions().slice(0, $fx.getDefinitions().indexOf($fx.getRawParam("replacing_param"))).concat([{
  "id": "replacing_param",
  "name": "Replacing specific param",
  "type": "boolean",
}]));

To remove one param, I would use the same approach:

$fx.params($fx.getDefinitions().slice(0, $fx.getDefinitions().indexOf($fx.getRawParam("deleting_param"))));

I wish I could change the params more easily.

The base58check uses this array of chars: "123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz"

Bitcoin base58 alphabet

Tezos base58 alphabet

Definition

Why is fxhash using this one? ("123456789abcdefghijkmnopqrstuvwxyzABCDEFGHJKLMNPQRSTUVWXYZ")

I get that order doesn't matter for the random generation of var fxhash, but I realized I was using the wrong index for base58 to decimal conversion because I was relying on the defined alphabet variable.

The template functionality of github fits this project intent and goal.