g-roma / freesound.js Goto Github PK

I get this error 500 when trying to use freesound.js in a Svelte/Vite dev environment. I looked around a bit and it seems to be something to do with Vite.... But I can't see how to solve it (yet). Thought I would mention it here.

The following function definition exists within the makeRequest() function definition:

var parse_response = function (response){
    var data = eval("(" + response + ")");
    success(wrapper?wrapper(data):data);
};

This function does not appear to be used anywhere. However, its contents appear to be replicated at line 87 and, somewhat, at line 73.

Is this intentional? An oversight?

This example has the private key in the "public" js file. I don't think this is good for production (and so do others: https://groups.google.com/forum/#!searchin/freesound-api/javascript/freesound-api/7DdxIx5FggU/6D0xnvxKK2kJ ). There should be a mention of this in the readme, together with possibilities to circumvent this. Maybe we could also introduce a php-file working as a specific proxy for this purpose? Or would that not fit this repo?

I wanted to extend your test.html to use MediaElementAudioSource with Web Audio API instead of just using AudioElement, something like this:

myAudioElement = new Audio(sound.previews['preview-hq-mp3']);
mySource = gAudioContext.createMediaElementSource(myAudioElement);
mySource.connect(gAudioContext.destination);

But no sound is heard, neither in Firefox nor in Chrome. Chrome gives this error message:

client-test.html:1 MediaElementAudioSource outputs zeroes due to CORS access restrictions for https://www.freesound.org/data/previews/96/96541_7037-hq.mp3

It is possible to have spaces in the search query. When run in a Node environment, at least, this results in a TypeError in makeRequest. It appears as though the makeUri method does not properly URIEncode the space character.

The same problem actually plagues an empty search query as well (e.g. searching tags only). This is because the empty string is replaced with a single space character (" "), which hits the same problem mentioned above.

I was able to bypass the empty search query issue locally by simply removing that space character and leaving it as the empty string (""). I am not sure if this works as expected or if it breaks something else that is expected.

From freesound.js#L84-87...

if (xhr.readyState === 4 && [200,201,202].indexOf(xhr.status)>=0){
    var data = eval("(" + xhr.responseText + ")");
    if(success) success(wrapper?wrapper(data):data);
}

I believe xhr.responseText is a JSON string, in which case JSON.parse can be used to safely parse the data. Is there a reason eval is used instead?

I'm having trouble using the API at all, due to CORS restrictions. All I tried to do was clone the repo, add my API key, and open the test.html page. But the result is just a bunch of errors like

XMLHttpRequest cannot load https://freesound.org/apiv2/search/text/?&page=1&filter=tag:tenuto%20durati…%2015.0]&sort=rating_desc&fields=id,name,url&query=violoncello&format=json. Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'null' is therefore not allowed access.

I am however able to use the api if I build a request using Postman, for what it's worth.

freesound.js doesn't require web-audio-api, is there a reason why it is a dependency? Should it be removed?

The example test.html shows how to retrieve sound from a text query. Moreover, it provides a way to then get the analysis of the retrieved sounds by performing another request.
However, the example does not show how to get analysis descriptors from text search request directly.

To make people more aware of the API good uses, it would be useful to have an example of how to perform a text query and specify some descriptors to be retrieved.

I plan to add a descriptors parameter in the example 2 of the test.html.