Giter VIP home page Giter VIP logo

Comments (5)

kltm avatar kltm commented on September 28, 2024

@pgaudet It does indeed seem not to be in the final neo.obo:

grep -c P06019 neo.obo
0

Okay, so let's peek at what's happening inside the "build" process. It exists in the upstream file:

grep -c P06019 uniprot_reviewed.gpi.tmp
1

It does not exist in the filtered version:

grep -c P06019 filtered_uniprot_reviewed.gpi.tmp 
0

Okay, so why is it getting filtered? Looking at the line in the upstream source:

UniProtKB       P06019  repc    Repressor protein c     repc|c|Mup01    protein taxon:10677             RefSeq:NP_050605.1|EMBL:AF083977        db_subset=Swiss-Prot|taxon_name=Escherichia phage Mu|proteome=gcrpCan

Looking through the code of the simple filter, it seems I coded in a regexp that was a little too aggressive, meaning that in some cases, taxon IDs that started with a "1" would get unnecessarily filtered. I've applied a fix that I believe will work.

Assuming it gets through the testing (starting now), we can either wait until the outage in two weeks to apply the change or coordinate an earlier time with @vanaukenk .

from neo.

kltm avatar kltm commented on September 28, 2024

Testing locally, it looks like we've bumped up the number of entities to 1625034 (from 1565994) and we now have the ones that were missing.

$ grep P06019 neo.obo 
id: UniProtKB:P06019

With no further action, this will go into production next week.

from neo.

pgaudet avatar pgaudet commented on September 28, 2024

Sounds good, thanks for debugging this.

Pascale

from neo.

pgaudet avatar pgaudet commented on September 28, 2024

Next step: check at the next Noctua release next Friday May 27th

from neo.

pgaudet avatar pgaudet commented on September 28, 2024

I can now find P06019

Thanks!

from neo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.