Giter VIP home page Giter VIP logo

Comments (12)

kltm avatar kltm commented on September 27, 2024

@dustine32 @tmushayahama Could you link the branch?

from web-gocam.

kltm avatar kltm commented on September 27, 2024

Or setup a PR so we can see the code/link changes? <-- preferred

from web-gocam.

dustine32 avatar dustine32 commented on September 27, 2024

@kltm Ah crud, you're right. Sorry! The branch is creatively named "dev": https://github.com/geneontology/web-gocam/commits/dev

I just realized there were a lot of formatting changes that clutter the changes relevant to this ticket (noctuaAlliancePathwayViewUrl env var, getAlliancePathwayView function, hook function into browse-models.component.html). I also need to remove the URL change to point back to the regular go-public endpoint for fetching the JSON files. Thinking of just copying the relevant changes to a new branch and PR.

from web-gocam.

kltm avatar kltm commented on September 27, 2024

No worries, sometimes things get confused. Operationally, the change would be:

  noctuaAlliancePathwayViewUrl: 'http://noctua.geneontology.org/workbench/noctua-alliance-pathway-preview/?model_id=',
  noctuaPathwayViewUrl: "http://noctua.geneontology.org/workbench/pathwayview/?model_id=",

?

My understanding is that we wanted to have this be an embedded widget in the /go-cam site and not have traffic heading towards the curation system.

from web-gocam.

dustine32 avatar dustine32 commented on September 27, 2024

Correct on both @kltm. I think (@thomaspd may want to weigh in) this is a short-term fix to at least direct users to a more digestible graph. The full widget embedding could be handled in a new ticket?

from web-gocam.

kltm avatar kltm commented on September 27, 2024

I think the question here is if this is a "project" or not. If @thomaspd and @pgaudet agree, I'm more than happy to take this as a software maintenance ticket, but we do need to track both of these.

from web-gocam.

thomaspd avatar thomaspd commented on September 27, 2024

Yes, this would be fine as a maintenance ticket. I think we're all in agreement that the public GO-CAM site should not point to our curation tool, and it's important to provide a visualization of these GO-CAMs so our users can understand what each of them represents.

from web-gocam.

kltm avatar kltm commented on September 27, 2024

@thomaspd I think the technical point that I miscommunicated is that this is still pointing to our curation tool and creating system traffic, load, and hinting bots. I agree that this is an improvement (getting rid of the login button if nothing else), but I still think we need to prioritized the "stronger" version of this much sooner than later.

from web-gocam.

kltm avatar kltm commented on September 27, 2024

@tmushayahama Believes that the stronger version of this--having the widget open on click--is quite easy, so we will take a look at that path first.

from web-gocam.

dustine32 avatar dustine32 commented on September 27, 2024

@tmushayahama can fill in the details but we discussed (with @thomaspd) that there is some Angular version issue that makes implementing the "on click widget open" much more difficult than expected. So, for a short-term fix, I can PR this change f648a87 and deploy.

from web-gocam.

kltm avatar kltm commented on September 27, 2024

@tmushayahama @dustine32 Yes, it would be good to get the details here for review.

from web-gocam.

kltm avatar kltm commented on September 27, 2024

Pulling this out of project for keeping traffic away from curation interfaces.

from web-gocam.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.