Comments (12)
@dustine32 @tmushayahama Could you link the branch?
from web-gocam.
Or setup a PR so we can see the code/link changes? <-- preferred
from web-gocam.
@kltm Ah crud, you're right. Sorry! The branch is creatively named "dev": https://github.com/geneontology/web-gocam/commits/dev
I just realized there were a lot of formatting changes that clutter the changes relevant to this ticket (noctuaAlliancePathwayViewUrl
env var, getAlliancePathwayView
function, hook function into browse-models.component.html
). I also need to remove the URL change to point back to the regular go-public endpoint for fetching the JSON files. Thinking of just copying the relevant changes to a new branch and PR.
from web-gocam.
No worries, sometimes things get confused. Operationally, the change would be:
noctuaAlliancePathwayViewUrl: 'http://noctua.geneontology.org/workbench/noctua-alliance-pathway-preview/?model_id=',
noctuaPathwayViewUrl: "http://noctua.geneontology.org/workbench/pathwayview/?model_id=",
?
My understanding is that we wanted to have this be an embedded widget in the /go-cam site and not have traffic heading towards the curation system.
from web-gocam.
Correct on both @kltm. I think (@thomaspd may want to weigh in) this is a short-term fix to at least direct users to a more digestible graph. The full widget embedding could be handled in a new ticket?
from web-gocam.
I think the question here is if this is a "project" or not. If @thomaspd and @pgaudet agree, I'm more than happy to take this as a software maintenance ticket, but we do need to track both of these.
from web-gocam.
Yes, this would be fine as a maintenance ticket. I think we're all in agreement that the public GO-CAM site should not point to our curation tool, and it's important to provide a visualization of these GO-CAMs so our users can understand what each of them represents.
from web-gocam.
@thomaspd I think the technical point that I miscommunicated is that this is still pointing to our curation tool and creating system traffic, load, and hinting bots. I agree that this is an improvement (getting rid of the login button if nothing else), but I still think we need to prioritized the "stronger" version of this much sooner than later.
from web-gocam.
@tmushayahama Believes that the stronger version of this--having the widget open on click--is quite easy, so we will take a look at that path first.
from web-gocam.
@tmushayahama can fill in the details but we discussed (with @thomaspd) that there is some Angular version issue that makes implementing the "on click widget open" much more difficult than expected. So, for a short-term fix, I can PR this change f648a87 and deploy.
from web-gocam.
@tmushayahama @dustine32 Yes, it would be good to get the details here for review.
from web-gocam.
Pulling this out of project for keeping traffic away from curation interfaces.
from web-gocam.
Related Issues (20)
- GO-terms retrieved as values of enabled_by
- Redirects system via file HOT 6
- Choose representative GO-CAMs to show on the main page
- AWS SSL certificates migration HOT 2
- Gene product display on GO-CAM page not ideal ? HOT 5
- Technical planning: Handover of GO-CAM site HOT 8
- Handover of GO-CAM API HOT 7
- The GO-CAM browser just spins--no display created HOT 6
- Different numbers of GO-CAMs between User Page & Browse Page with filter
- Display only causal models on GO-CAM site HOT 14
- External links should go to new AmiGO GO-CAM pages HOT 9
- Remove GO-CAM download card from /go-cam site HOT 7
- Browse Page - GO-CAM with same user using multiple providedBy duplicates user name
- Access to development models
- Search by Gene Product and PMID HOT 2
- Several Features & Improvements HOT 7
- SIF Archive Download HOT 2
- GO-CAM Documentation
- Feedback HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from web-gocam.