Replace Flake8 & isort with Ruff about pelican HOT 4 OPEN

Hi @FriedrichFroebel. The proper version of Flake8 for use with this repository is listed in the pyproject.toml file.

As for this bit…

This is related to flake8 6.0.0 dropping the --diff option

Speaking of dropping, I think it's time to drop Flake8. I'm tired of these shenanigans and the repeatedly rude manner in which Flake8 maintainers conduct themselves. (I'm going to refrain from posting relevant links here, as I have neither the time nor the interest in getting mired in pointless Internet wars.)

So, Friedrich, I'm sorry for hijacking your issue, but I have changed the intended resolution of this issue accordingly. I have already done an experiment in a plugin repo in which I replaced Flake8 (and isort) with Ruff, and it seems to working very well so far: pelican-plugins/touch@f93876d

I intend to make a similar transition here in this repository when I can find the time.

from pelican.

Thanks for the explanations. I had missed the versions inside the pyproject.toml file, as I assumed that the tasks.py file would install the required stuff (which proved to be wrong). The CONTRIBUTING guide was of no big help here either for now.

from pelican.

This resulted in flake8 not being installed first (not installed by invoke install)…

There is no invoke install task. If you tried that, Invoke should have rightfully responded with: No idea what 'install' is!

I assumed that the tasks.py file would install the required stuff (which proved to be wrong).

For me, it does indeed install the required stuff, including all needed linter tools, as long as the proper invocation is used:

invoke setup

The CONTRIBUTING guide was of no big help here either for now.

All of the required steps should be meticulously described in the Setting Up the Development Environment section of the documentation, including the above-mentioned invoke setup step.

from pelican.

Thanks for the hint. I actually assumed that https://github.com/getpelican/pelican/blob/master/CONTRIBUTING.rst would be the official contribution guide, as this is what GitHub automatically points to as well. Nevertheless, I managed to get it working somehow, but yes, good documentation is always appreciated.

from pelican.