Ability to set the SentryUser via the SentryEvent interface? about raven-csharp HOT 8 CLOSED

@ryankanno Thanks for reporting this. I've released a 2.1 prerelease on NuGet that I would very much appreciate if you could test and report back whether fixes the problem or not.

from raven-csharp.

@ryankanno We've also experienced this problem. The way we fixed it is to inject a custom SentryUserFactory in the RavenClient, in which we override the OnCreate function. Here we set the properties of the user.

from raven-csharp.

@lwhuybrechts I did look at https://github.com/getsentry/raven-csharp/blob/develop/src/app/SharpRaven/RavenClient.cs#L288 to do that, but in my case, I wanted to dynamically set properties based on constructs that weren't in a global scope. I could have it injected it somewhere where it would be accessible (like in the HttpContext), but it felt a bit like I was fighting the lib. :)

from raven-csharp.

@ryankanno If you have ideas on how it could be done more elegantly, please write them here or submit a pull request. I don't have time to look into this myself in a while, I'm afraid.

from raven-csharp.

@asbjornu I could take a stab at it. Is there any historical context as to why it wasn't exposed on the SentryEvent interface? (Only so that I don't go down routes that weren't expected). At first glance, it seems like the resulting JsonPacket could just absorb the User from the SentryEvent interface (if it were exposed).

from raven-csharp.

@ryankanno There's no particular reason I can think of, so please add it the way you think is best and do a PR in which we can discuss the details. 👍

from raven-csharp.

Closing this in await for a pull request.

from raven-csharp.

Did anyone attempt a pull request? I might do so if no one has as I've made the changes locally to inject user as part of the Capture method.

from raven-csharp.