ghofranebenhmaid / hyf-homework Goto Github PK

Hi :)
Great work!
Responsive solution and looking good. Please look at the comments and re-commit
Keep it up!

Both API giphi and weather shows results and UI is good.
functionality is written very well, but the explanation in a few words in comments can give code more understanding. while naming files-: proper name to the file can also be good practice so that easy to identify the related file.
Overall "excellent" code and logic.

Something went wrong with your code . Please check .
Below is the feed back for the code which is uploaded :
Flight booking full name function - no need to write this function twice.

Event application

I don’t know why do you use “for ” here
for(var i=eventDay ; i>6;) - for is used when you want to do loop but I don’t see you used for that . Maybe you want to write like this:
var i=eventDay ;
if(i>6){
eventDay = eventDay-7;
i = eventDay;
}

Weather wear is incomplete.
Student Manger and Candy Helper is missing

Impressive work 🥇 .
Everything works as per requested. You are now expert 👍
Enjoy coding 👍

Beautiful work with graphics moving element one by one and all at once. Not only the code point of view but page refresh and both functionalities on click event, it was really nice to see beyond the programming (client expectation-side ) approach.

Promises resolve after set time: you made it very complicated, and it's not working either
rewrite time: this works but I felt it can be written in a more simple way.

Movies : very good. try to declare variables as const more than let.

overall very good job, Best wishes!

looks like the code is not running,(so I was not able to see the output) plz confirm if it works on your side?
with first 2 short and long title ex. :
filter function can be used differently, you can directly compare the length of the title with a specific number.

Good job 👍 . Everything looks good to me except only one task. Sorry to hear that you were sick.

ItemRemoval Task -
Task was removing random name using random method.
Here, you are choosing the position and removing it.
For removing random name from the array either you use for loop inside If statement or you can just check the index of the element which is matching then slice it.

Enjoy Coding 👍

Hi ,
Great job 🥇 . Everything looks fine for me. I can see you used "let" that's good. I have only one comment for you and that needs to fix.
Task - Goodboy-Oldboy (A dog age calculator)
I think you have not noticed the logic for dog year age calculation : " string out: "Your dog will be 10 human years old in 2027" or "Your dog will be 70 dog years old in 2027 ".

Hi :)
Very good!
Html is only missing the name property a few placed
I like the css and you managed to create large and mobile friendly checkboxes and radio elements
Very nice animation to progress, Primary foxus is on the html for this homework
Great work!

Very good use of DOM, and nicely written JS code.
All functionalities works and shows the result as well.
suggestion :

<script src="main.js"></script>

in HTML file , its always better to specify these src at the top. (although everything is allow in JS.)