Giter VIP home page Giter VIP logo

Comments (5)

allochi avatar allochi commented on April 20, 2024

gin uses httprouter as HTTP request router, if you check "Named parameters" at the link below, you will see that this is how httprouter is designed, by explicit matches, so you can't have /user/new and /user/:user.

https://github.com/julienschmidt/httprouter#named-parameters

from gin.

allochi avatar allochi commented on April 20, 2024

Just to correct myself, you can't have both on the same HTTP method, so you can have

r.GET("/user/:user", showUser)
r.POST("/user/new", newUser)

But assuming you want to return html and json formats of the same user, you may do this

r.GET("/user/:user", showUserHTML)
r.GET("/user/:user/json", showUserJSON)

from gin.

javierprovecho avatar javierprovecho commented on April 20, 2024

@allochi let's develop infinite middlewares. here is your solution:

package gin

func DefaultParam(p string, f HandlerFunc) HandlerFunc {
    return func(c *Context) {
        if c.Params.ByName("name") == p {
            f(c)
            c.index = AbortIndex
        }
    }
}

and you use it like this:

r.GET(
    "/test/:name",
    gin.DefaultParam(
        "json",
        func(c *gin.Context) {
            c.String(400, "default param detected")
        }),
    func(c *gin.Context) {
        c.String(200, "the param is "+c.Params.ByName("name"))
    })

from gin.

allochi avatar allochi commented on April 20, 2024

Smart πŸ˜„, but too much, I would probably just switch that in the handler, specially if I have more than one value to check.

I was just explaining that httprouter uses explicit matches, so it's not a bug in gin.

from gin.

javierprovecho avatar javierprovecho commented on April 20, 2024

Of course, the best way to handle this is to use a Switch. With my example just wanted to show how flexible is Gin and how to design an alternative when you can't modify your handlers. We all know that combining two handlers in one hurt our eyes.

So... because Ali explained why this error is not part of Gin, and I posted a small middleware to help get around, I'm closing the issue.

from gin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.