Giter VIP home page Giter VIP logo

Comments (7)

manucorporat avatar manucorporat commented on March 29, 2024

Can you show the api.Patch struct?

from gin.

benschw avatar benschw commented on March 29, 2024
type Patch struct {
    Op    string `json:"op" binding:"required"`
    From  string `json:"from"`
    Path  string `json:"path"`
    Value string `json:"value"`
}

after digging i see that it is failing in the Validate function: https://github.com/gin-gonic/gin/blob/master/binding/binding.go @ line 156

Since my json is successfully getting populated, but Validate is panicing, i've worked around it successfully like so:

defer func() {
    if r := recover(); r != nil {
        // do work with json here
    }
}()
c.Bind(&json)

from gin.

manucorporat avatar manucorporat commented on March 29, 2024

you do not need to do that, it should never crash. I am working in a fix.

from gin.

manucorporat avatar manucorporat commented on March 29, 2024

The fix is ready!

from gin.

benschw avatar benschw commented on March 29, 2024

very cool, this fixes it for me too.
thx!

from gin.

benschw avatar benschw commented on March 29, 2024

sorry, I probably shouldn't have closed the ticket on you. thanks again

from gin.

manucorporat avatar manucorporat commented on March 29, 2024

Just an advice, use c.Bind() instead of c.EnsureBody(). EnsureBody() is a deprecated method :)
You also can use c.BindWith() if you want a strict parsing:

c.Bind(&mystruct) // it checks the content-type
c.Bind(&mystruct, binding.JSON) // forces the system to use the JSON binding

from gin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.