Comments (5)
Ouch.. yeah right. That indeed is a problem I didn't think about.. Damn it. No matter which provider is chosen the plugin is requesting Github's /markdown
endpoint. Since that request (currently) is not authenticated, Github rate limits heavily to 60 requests per minute: https://developer.github.com/v3/#rate-limiting
It's alright for 99% of the articles but heavily trafficked blogs will run into problems. Or even during development, as you encountered I guess.
Let me fix that soon. And please bump if I forget about it.
from wordpress-markdown-git.
Ah, actually I think this is fine the way it is tbh. Github says they restrict to 60 calls per hour per IP, meaning a single computer would have to request a post more than once a minute 60 times before the hour ends in order to be rate limited.
I think it's reasonable to assume that that won't happen unless you're in heavy testing.
I'll close but anyone who thinks their users are reading like pros can implement this :)
from wordpress-markdown-git.
Argh, no idea what's wrong today..
Of course it's a problem.. The "user" is the server and can actually only serve 60 requests per hour which doesn't require a lot of users to achieve.
Ok, this overtakes a lot of things in the priority lane. Will fix asap.
And sorry for the spam..
from wordpress-markdown-git.
Auto-closed by Github and my stupidity. This is fixed now in current master
@LuigiBella. You'll have to provide your Github credentials in config.json
to increase the API rate limit.
from wordpress-markdown-git.
Also this is fixed with 1.0.2 release:
https://wordpress.org/plugins/documents-from-git/
Please re-open if this issue continues happen.
from wordpress-markdown-git.
Related Issues (20)
- GitLab rate limited HOT 3
- Enable dynamic caching
- plugin does not respect dark mode HOT 4
- Small Typo on Readme. :)
- [feature request] support for gitlab wiki pages HOT 12
- WP plugin taking too long HOT 5
- Support for checkbox [x] HOT 3
- Doesn't update ipynb when git is updated. HOT 7
- [Feature request] Skip a given number of lines HOT 2
- Anchor links to headers don't work HOT 1
- Gitlab local API HOT 3
- since update: error message that I reached API call limit HOT 2
- Styles are not enqueued HOT 1
- installation on PHP8.0 HOT 3
- Accessibility with Gitlab markdown flavor HOT 2
- Include a link to settings in plugin page
- Removing cache_ttl does not flush cache HOT 3
- Inline codeblocks not working correctly? HOT 2
- Deprecate this plugin HOT 6
- 404 - Not found - Unable to add .ipynb as blogpost HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wordpress-markdown-git.