Add semver version to api/status/buildinfo endpoint about tempo HOT 6 OPEN

There was some discussion and initial improvements in this issue.

from tempo.

Hey @joey-grafana, Can you explain this a bit more please ?

version field in response comes from main.Version flag set when compiling the program. For normal releases, It's set to a semver value and the response is what you'd expect.

{"version":"2.5.0","revision":"46dad3411","branch":"HEAD","buildUser":"","buildDate":"","goVersion":"go1.21.3"}

If I understand correctly, With this PR, you always want a semver value here ?

from tempo.

Hey this does not work correctly for cloud deployments as the versioning is slightly different. We are basing our check on there being a semver version present.

@fabrizio-grafana I know you worked on the feature initially so if you have any additional context please feel free to share.

from tempo.

from tempo.

Since the version depends on the tag/branch we have discrepancies between enterprise/non-enterprise versions.

One simple approach could be having a VERSION file directly in the root of the repo and then read it when building like Mimir does:

https://github.com/grafana/mimir/blob/0e8c09f237649e95dc1bf3f7547fd279c24bdcf9/VERSION#L1

https://github.com/grafana/mimir/blob/0e8c09f237649e95dc1bf3f7547fd279c24bdcf9/Makefile#L17

from tempo.

This issue has been automatically marked as stale because it has not had any activity in the past 60 days.
The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed after 15 days if there is no new activity.
Please apply keepalive label to exempt this Issue.

from tempo.