Giter VIP home page Giter VIP logo

graphql-wg's People

Contributors

abernix avatar alan-cha avatar andimarek avatar benjie avatar binaryseed avatar bod avatar brianwarner avatar captbaritone avatar dariuszkuc avatar dschafer avatar eapache avatar fotoetienne avatar hwillson avatar ivangoncharov avatar leebyron avatar magicmark avatar martinbonnin avatar michaelstaib avatar mike-marcacci avatar mjmahone avatar mmatsa avatar olegilyenko avatar rivantsov avatar robrichard avatar robzhu avatar sachee avatar twof avatar urigo avatar wincent avatar yaacovcr avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

graphql-wg's Issues

Schedule working session with Input Union RFC champions

Our next step in the Input Union RFC process is to gather the individual solution champions for a working session where we can dive into the details of solutions and try to make some progress towards a proposed solution.

Our aim is to have this meeting about 1 week before the next general Working Group meeting:

Current champions: @leebyron @binaryseed @eapache @benjie

Is there a scheduled next meeting?

I plan on pushing for this RFC again, and need to resolve merge conflicts in the RFC and reference implementation but want to plan it so I don't have more conflicts to fix by the time people can look at it.

Has there been any out-of-band discussion about the next meeting? If so, could we get a new agenda item in the repo?

[2020-09-03] License missing in scalars subproject

It was pointed out that the scalars subproject does not have a license currently. Lee suggested we'd use the OWFa license, but actioned himself to follow up with Brian to make sure licensing is done right.

Andreas: that's why I've opened this issue. graphql/graphql-scalars#7
Lee: GraphQL foundation gives us clear legal rules so people know how they can use these scalars.
Andreas: agreed; this is really nice.
ACTION - Lee: I'll follow up with Brian and make sure he's prioritising this.


Note: Action Item issues are reviewed and closed during Working Group
meetings.

[2020-09-03] Update @defer/@stream RFC with more thorough explanation of fragments vs fields

Discussion related to limiting @defer/@stream to only fragments vs also allowing it on fields. This was explained well in WG, Rob agreed to add it to the RFC

ACTION - Rob: Rob: I'll update the RFC PR with a more thorough explanation and then we'll get that into the spec as well.


Note: Action Item issues are reviewed and closed during Working Group
meetings.

GraphQL @defer and @stream

We’ve been experimenting with @defer and @stream at Facebook for a while now -- Lee first discussed the idea of @defer and @stream in 2016. Over the last three years, we've done a ton of iterations as we uncovered and resolved issues and edge cases following that initial approach. We're now seeing a renewed demand for these ideas in the open source community:
graphql/graphql-js#2318
graphql/graphql-js#2319

Given that Facebook’s increased internal usage makes us more confident in our approach, it seems like a good time to start a discussion of what the next steps would be. Opening this issue with some strategic questions:

  • What's the best way to drive @defer and @stream standardization?
  • Should these features be part of the official spec or a supplemental specification (e.g. connections)?
  • If we decide these features are worthy of standardization, what's the best way of driving towards alignment? Should we set up a stream/defer focused-WG?

How to encourage discussions on PRs in GraphQL Spec repo?

Just as a continuation on disscusion that we had during WG.

A few actionable ideas so far are:

  • More descriptive tags on issues and PRs
  • Have a "This week in GraphQL specification" newsletter

Would be great to hear other ideas?

[Experiment] Generic bulk queries in GraphQL

Public docs at https://help.shopify.com/en/api/guides/bulk-operations/, but this is still experimental/beta.

At Shopify we've seen a lot of clients who need to fetch large quantities of data (e.g. all 10k products on a shop). We follow relay pagination, so typically they would do this via paginated requests (e.g. 100 requests for 100 products each) but this is inefficient in that it results in a lot of round-trips, a lot of query processing overhead, some concatenation logic on the client, etc.

As a better solution, we're experimenting with a subtle variant of our GraphQL schema (or perhaps more accurately a variant of the relay pagination spec?) where clients don't specify any of the regular first/last/before/after arguments. Instead, our server iterates over pages of the query transparently, and returns the total results (e.g. all 10k products) in a single file downloadable from S3 or similar storage hosts. Details are at the link above.

As a general pattern I think this might be something that is useful or at least interesting to the broader community, which is why I wanted to share it. There was some interesting conversation in the working group meeting over whether this was technically spec-compliant or not, and I'm also interested (if it works out long-term) in potentially working this into the spec. In my mind it's similar to subscriptions, in that it's an another variant on how the data actually gets returned, built on top of the same fundamental schema (normal queries are synchronous pull, subscriptions are synchronous push, and this bulk API is asynchronous pull).

We've also talked about variations of this approach where it's more explicitly not-spec-compliant, e.g. making a separate end-point for these requests which takes the graphql request in the normal way but just returns the ID of the job that was launched instead of any spec-compliant response.

Whatever thoughts or opinions you have, please share. We're obviously paying a lot of attention to what our clients think of this, but we also want to be good citizens if there is interest or concern from the GraphQL community.

[2020-09-03] Organize input value deprecation spec text update and GraphQL.js merge

Lee: Ivan, since you’ve been working on graphql.js change do you want to champion this spec change proposal?
Ivan: I need a native language speaker to review changes; I've pinged Benjie before and he's been really helpful with it.
Lee: ACTION - Ivan - get the GraphQL.js change in and organize updating the spec texts.


Note: Action Item issues are reviewed and closed during Working Group
meetings.

Schedule a one-off for GraphiQL discussions

👋 - I kickstarted some discussion on twitter about a what could GraphiQL 2.0 (or, I guess 1.0 as it's still not there yet :D ) after exploring some wireframes.

We should schedule a one-off meeting to talk about:

  • What are the current issues with GraphiQL?
  • What could / should GraphiQL do?
  • Could we find a way to integrate ( or support the integration of) the features from GraphQL playground and/or explorer?

[2020-09-03] Contact Matt about Flow support in TypeScript version of GraphQL.js

Ivan: I should also contact Matt about Flow support because we need to figure out how to migrate to TypeScript without breaking Flow clients (at Facebook specifically)


Note: Action Item issues are reviewed and closed during Working Group
meetings.

[2020-09-03] Add checkbox to issue template to confirm agreements are signed

[Regarding cutting a version of the spec]

Ivan: I've been merging stuff into the spec/etc; if you need me to stop let me know.
Lee: If you see that contributions come from new contributors, you can flag and let Brian know.
[...]
Ivan: if someone wants to help, adding a checklist in the issue template would be a great contribution
ACTION - Lee: mention this issue template idea to Brian


Note: Action Item issues are reviewed and closed during Working Group
meetings.

[2020-07-02] Read over GraphQL Custom Scalar PR

ACTION - Lee - read over this and make sure we're not missing anything, and perform the merge.
Lee: it should be clear that you can have scalars in your own domain that are only used in your domain.
Ivan: we should allow vendor URLs. It reduces our workload if people can use vendor-specific things - they'd be less pushy about pushing their scalars to be standard.
ACTION - Lee - make minor changes as a last patch before merging

Custom scalar PR: graphql/graphql-spec#649


Note: Action Item issues are reviewed and closed during Working Group
meetings.

[2020-06-11] GraphQL Scalars hosting - schedule call with Andi

Lee: if we reach out I'd not be surprised if we found volunteers to make this happen.
Ivan: We need Andi to be involved in the conversation. Can we schedule a call to talk to Andi and have a conversation about how to proceed?
ACTION - schedule a call with Andi (hour and a half)


Note: Action Item issues are reviewed and closed during Working Group
meetings.

[2020-08-06] Determine contributors, owners, merge rights for GraphQL-js

Lee: lets put a plan together for increasing bus factor. Two actions:

  1. Start a Graphql.js specific call - focussed on strategy, not specific code (see #485)
  2. List our contributor to GraphQL.js; specify “owners”. Who do we want to give review, but not yet merge capabilities? Keep it to a tight core set.

Note: Action Item issues are reviewed and closed during Working Group
meetings.

Spec cut date?

I'd like to start a discussion about when we should cut the next release of the GraphQL specification.

It has been 16 months since the last release, and some significant changes and iterative improvements have been made in that time. The previous two release have 20 months between them.

I'd like to return to an annualized and predictable schedule for specification releases.

[2020-08-06] Add YouTube WG links to the notes

Benjie - How to get recordings?
Lee - Zoom provides them after a few weeks as raw video files. Eventually we want to get them on youtube.
Ivan - The foundation guys have figured out how to publish on youtube!
Lee - let’s add youtube link to notes after the fact


Note: Action Item issues are reviewed and closed during Working Group
meetings.

GraphQL over HTTP specification

We previously discussed the possibility of such spec and I went ahead and create MVP:
https://github.com/APIs-guru/graphql-over-http
It would be great if we adopt it under GraphQL Foundation as a complementary spec.
I'm still interested in collaborating but I would love if the community and industry leaders take a lead and we can form a subgroup to work on it.

[2020-07-02] Moving the @deprecated directive on Input Fields RFC to Stage 2

[ACTION - Lee] - Add RFC 2 tag to PR
[ACTION] - Add SHOULD statement to spec recommending that it is generally ill-advised to add @deprecated to a non-null argument or input field unless there is a default value provided.
[ACTION] - merge spec PR to master
[ACTION - Ivan] - Add schema validation to GraphQL.js that enforces @deprecated on nonnull Moved to #518
[ACTION - Evan] - talk to Shopify team and others to determine SHOULD vs MUST. Moved to #517


Note: Action Item issues are reviewed and closed during Working Group
meetings.

[2020-09-03] Create PR merging policy and grant more contributors maintainer access to WG repo

Ivan: if we write a document with policies, we can have more people help with merging.
Lee: we can be more liberal with giving merge access to the WG repo. Anyone who's a frequent guest of these meetings we can give commit access to.
Ivan: especially the champions. You just promise to not merge anything in other people's RFCs, only in your RFC.
ACTION - Lee: make this happen


Note: Action Item issues are reviewed and closed during Working Group
meetings.

[2020-08-06] Create Issues for Action items from previous calls

Go through notes for previous calls and create action items for them.
Note: @benjie already created all action items for the Sep2020 call, so Aug2020 is the next target 🎯

  • assignee(s): any volunteer
  • source: something that we should do every month

  • September 2020
  • August 2020
  • July 2020
  • June 2020
  • May 2020

[2020-09-03] Call to organize collaboration on TypeScript migration of GraphQL.js

Ivan: TypeScript migration will be a breaking change. Let's discuss it on a call since not everyone's interested in JavaScript implementation. I think it's important to allow new contributors; Flow is a barrier for many people to contribute. TypeScript is easier, I've heard from many contributors.
[...]
Dotan: any issues, if you need help, we can put people to work on it with you. If you need help, we are here.
ACTION - Ivan - organize a call with Dotan to figure out a strategy.


Note: Action Item issues are reviewed and closed during Working Group
meetings.

[2020-07-02] Require Argument Uniqueness

Ivan: validation for type system in chapter 3 requires uniqueness of type names, field names, etc; but we forgot to specify arguments were unique. It's not an editorial change, but pretty uncontroversial.
Lee: on the topic of having a process; we need to have a reference implementation before calling it final stage.
[...]
ACTION - Ivan - implement in GraphQL.js


Note: Action Item issues are reviewed and closed during Working Group
meetings.

Updating CLAs and copyright notices in GraphQL repos

Some issues maintained by the GraphQL foundation still point to Contributor Licence Agreements hosted by Facebook, i.e.:

We could either remove the requirement to sign a CLA, or provide means to do so via the foundation (if that is possible).

A related issue for libgraphqlparser is how to deal with "facebook" in namespaces, as changes are breaking.

Agenda: Define process for the changes to the specification

At the moment it's very hard to track which features will be included in the next release.

For example, the absolute majority of the community thinks that IDL is already a part of the spec since it is implemented in all major libraries. However, it's still not merged into a spec and there is no clear indication of this PR status.

I propose to define a pipeline for all the major changes with stages marked as labels applied to PRs. I suggest using TC39 process document as the base and adapt it to the specifics of GraphQL (reference implementation, WG, etc.).

It will give the community a sense of understanding on what's happening with GraphQL and allow library authors to do an educated decision on what experimental features they should support.

As for the editorial changes like grammar, examples, clarifications, etc. I propose to add separate simplified pipeline.

Should we discuss this at the next meeting?
Slides here

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.